Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test #96650

Closed
wants to merge 17 commits into from
Closed

Test #96650

wants to merge 17 commits into from

Conversation

janvorli
Copy link
Member

@janvorli janvorli commented Jan 8, 2024

No description provided.

@janvorli janvorli added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Jan 8, 2024
@janvorli janvorli self-assigned this Jan 8, 2024
@janvorli
Copy link
Member Author

janvorli commented Jan 8, 2024

/azp run runtime-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@janvorli
Copy link
Member Author

janvorli commented Jan 9, 2024

/azp run runtime-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@janvorli
Copy link
Member Author

janvorli commented Jan 9, 2024

/azp run runtime-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@janvorli
Copy link
Member Author

/azp run runtime-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@janvorli
Copy link
Member Author

/azp run runtime-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@janvorli janvorli force-pushed the test-new-eh-by-default-2 branch from a1ff3b6 to 373564a Compare February 1, 2024 00:20
@janvorli
Copy link
Member Author

janvorli commented Feb 1, 2024

/azp run runtime-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

The handling was backwards - we were first checking the wrapped
exception and then the unwrapped when matching handler type and the
exception type. But we should not try to match the wrapped ones if the
module doesn't have the flag set to handle wrapped exceptions.
@janvorli
Copy link
Member Author

janvorli commented Feb 1, 2024

/azp run runtime-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@janvorli
Copy link
Member Author

janvorli commented Feb 1, 2024

@AaronRobinsonMSFT could you please approve this PR?

I am sorry, wrong PR.

And a bit of cleanup
@janvorli
Copy link
Member Author

janvorli commented Feb 2, 2024

/azp run runtime-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@janvorli
Copy link
Member Author

janvorli commented Feb 3, 2024

/azp run runtime-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@janvorli
Copy link
Member Author

janvorli commented Feb 3, 2024

/azp run runtime-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@janvorli
Copy link
Member Author

/azp run runtime-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@janvorli janvorli closed this Feb 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-coreclr NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants