enforce FIELD_OFFSET_LAST_REAL_OFFSET size limit for InlineArrays

[VSadov]

Fixes: #95193

• Fixes a faulty test that was passing for a wrong reason
• Enforces the limit in a case of sequential layout
• Increases the limit to FIELD_OFFSET_LAST_REAL_OFFSET

[lambdageek]

(I'm still learning about the CoreCLR type system) CoreCLR bits lgtm

[jkotas]

Is this fixing the silent overflow in sequential layout too? #95193 (comment)

[VSadov]

Is this fixing the silent overflow in sequential layout too?

No. We can fix that, but it should probably be a separate change.
If it is an older issue, we may not need to port that to 8.0

[VSadov]

I've logged an issue to follow up with other silent overflows in sequential layout: #97412

[ghost]

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

[VSadov]

@lambdageek - while not strictly necessary, it may make sense to increase the limit on Mono as well.

I am not sure if Mono has some other limits for the size of a struct. If such limit is lower, it might make sense to have a different limit.

[VSadov]

Thanks!!

[VSadov]

/backport to release/8.0-staging

[github-actions]

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7663297851