Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add regex test suggested by recent fix #97532

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

danmoseley
Copy link
Member

relates to #97463 which was for negative lookahead. this is for negative lookbehind.

@ghost
Copy link

ghost commented Jan 26, 2024

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

relates to #97463 which was for negative lookahead. this is for negative lookbehind.

Author: danmoseley
Assignees: danmoseley
Labels:

area-System.Text.RegularExpressions

Milestone: -

@danmoseley
Copy link
Member Author

@lewing I assume I can merge on red "smoke tests" but am I supposed to open an issue with matching pattern? How do I know?

Clearly irrelevant to this PR but I believe there's ceremony around merge on red in this repo..

@danmoseley danmoseley merged commit eae6da8 into dotnet:main Jan 26, 2024
109 of 111 checks passed
@danmoseley danmoseley deleted the retest branch January 26, 2024 20:10
@danmoseley
Copy link
Member Author

I merged as I assume the two linked issues cover everything -- but I'm not sure how to tell? maybe there's a doc about this.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants