Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add separate properties for keep-in-sync versions #97643

Merged
merged 6 commits into from
Feb 6, 2024
Merged

Add separate properties for keep-in-sync versions #97643

merged 6 commits into from
Feb 6, 2024

Conversation

am11
Copy link
Member

@am11 am11 commented Jan 29, 2024

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-HostModel Microsoft.NET.HostModel issues label Jan 29, 2024
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jan 29, 2024
@am11 am11 requested a review from ViktorHofer January 29, 2024 14:11
@ghost
Copy link

ghost commented Jan 29, 2024

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

Issue Details

#97021 (comment)

Author: am11
Assignees: -
Labels:

area-HostModel, community-contribution
Milestone: -

@am11 am11 added area-Infrastructure and removed area-HostModel Microsoft.NET.HostModel issues labels Jan 29, 2024
@ghost
Copy link

ghost commented Jan 29, 2024

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

#97021 (comment)

Author: am11
Assignees: -
Labels:

area-Infrastructure, community-contribution
Milestone: -

@am11 am11 mentioned this pull request Jan 29, 2024
Merged
@am11 am11 force-pushed the feature/package-versioning branch 2 times, most recently from 401f846 to 96e5e8b Compare January 29, 2024 16:03
MichaelSimons
MichaelSimons reviewed Jan 29, 2024
View reviewed changes
eng/Versions.props Outdated Show resolved Hide resolved
@am11
Copy link
Member Author

am11 commented Jan 29, 2024

Failures are known (per Build Analysis).

This was referenced Jan 29, 2024
Closed
Closed
Closed
@am11 am11 requested a review from maraf as a code owner January 30, 2024 20:44
@am11 am11 force-pushed the feature/package-versioning branch from c9618be to 23129d8 Compare January 30, 2024 20:53
@am11 am11 requested a review from sbomer as a code owner January 30, 2024 20:53
@am11 am11 force-pushed the feature/package-versioning branch from 23129d8 to b26a4a2 Compare January 30, 2024 20:56
This was referenced Jan 31, 2024
Open
Open
Open
Closed
@akoeplinger
Copy link
Member

akoeplinger commented Jan 31, 2024 •
edited
Loading

I've fixed the msbuild task projects to use NetCoreAppToolCurrent and NetFrameworkToolCurrent, we can leverage the transitive references for System.Reflection.Metadata from msbuild packages in those projects so we don't need to explicitly reference it.

ViktorHofer
ViktorHofer reviewed Jan 31, 2024
View reviewed changes
eng/liveILLink.targets Outdated Show resolved Hide resolved
@akoeplinger akoeplinger force-pushed the feature/package-versioning branch from b4b82fe to a040a48 Compare January 31, 2024 12:55
@am11
Copy link
Member Author

am11 commented Feb 6, 2024

Extra changes by @akoeplinger reverted. Lets move them to a separate PR.

@am11 am11 requested a review from jkotas February 6, 2024 05:16
This was referenced Feb 6, 2024
Closed
Closed
Closed
@ViktorHofer
Copy link
Member

ViktorHofer commented Feb 6, 2024 •
edited
Loading

@am11 do you have a back-up of @akoeplinger's changes?

ViktorHofer
ViktorHofer reviewed Feb 6, 2024
View reviewed changes
eng/Versions.props Outdated Show resolved Hide resolved
ViktorHofer
ViktorHofer reviewed Feb 6, 2024
View reviewed changes
eng/Versions.props Outdated Show resolved Hide resolved
@am11
Copy link
Member Author

am11 commented Feb 6, 2024

@am11 do you have a back-up of @akoeplinger's changes?

Yup:
image
so we can see it like this: https://github.com/dotnet/runtime/commits/421482baf82d2cb0887da31ad73a39b15afdb855

@ViktorHofer
Copy link
Member

ViktorHofer commented Feb 6, 2024 •
edited
Loading

Sweet, I didn't know that is possible on GH 👍

@ViktorHofer ViktorHofer merged commit 994e272 into dotnet:main Feb 6, 2024
190 of 194 checks passed
KidiIT

This comment was marked as spam.

Sign in to view

lewing
lewing reviewed Feb 8, 2024
View reviewed changes
eng/Versions.props
@@ -129,7 +129,9 @@
<SystemDrawingCommonVersion>8.0.0</SystemDrawingCommonVersion>
<SystemIOFileSystemAccessControlVersion>5.0.0</SystemIOFileSystemAccessControlVersion>
<SystemMemoryVersion>4.5.5</SystemMemoryVersion>
<SystemReflectionMetadataVersion>7.0.0</SystemReflectionMetadataVersion>
<SystemReflectionMetadataVersion>9.0.0-alpha.1.24072.1</SystemReflectionMetadataVersion>
<!-- Keep toolset versions in sync with dotnet/msbuild and dotnet/sdk -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't the versions in msbuild or VS afaik

Copy link
Member

@lewing lewing Feb 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/dotnet/msbuild/blob/main/eng/Versions.props#L38-L39

https://github.com/dotnet/msbuild/blob/vs17.9/eng/Versions.props#L38-L39

Copy link
Member Author

@am11 am11 Feb 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, see #97021 (comment) and #97643 (comment). TL;DR, we need to keep version of SRM in HostModel lower or equal (when everything is out of beta/preview) than MSBuild and SDK. SDK and runtime are currently using 7.0, MSBuild has moved to 8.0.

KidiIT

This comment was marked as spam.

Sign in to view

@lewing
Copy link
Member

lewing commented Feb 9, 2024

see #97836

@am11
Copy link
Member Author

am11 commented Feb 9, 2024

see #97836

Is this the correct issue? Not seeing the relevance. 👀

KidiIT

This comment was marked as spam.

Sign in to view

@lewing
Copy link
Member

lewing commented Feb 10, 2024

see #97836

Is this the correct issue? Not seeing the relevance. 👀

nope, wrong paste buffer. apologies for the confusion

@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KidiIT KidiIT KidiIT left review comments

@MichaelSimons MichaelSimons MichaelSimons left review comments

@lewing lewing lewing left review comments

@ashaurtaev ashaurtaev ashaurtaev approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@maraf maraf Awaiting requested review from maraf maraf is a code owner

@sbomer sbomer Awaiting requested review from sbomer sbomer is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar

@jkotas jkotas Awaiting requested review from jkotas

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

Assignees
No one assigned
Labels
area-Infrastructure community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@am11 @akoeplinger @ViktorHofer @lewing @MichaelSimons @ashaurtaev @KidiIT