Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Unrestored/UnrestoredTypeKey flags #97674

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Remove Unrestored/UnrestoredTypeKey flags #97674

merged 5 commits into from
Jan 31, 2024

Conversation

elinor-fung
Copy link
Member

These should not be needed now that we NGEN support is gone.

@ghost ghost assigned elinor-fung Jan 29, 2024
This was referenced Jan 30, 2024
Closed
Open
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 9.0.0 milestone Jan 30, 2024
davidwrighton
davidwrighton approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@davidwrighton davidwrighton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've noticed a few comments that need updating, (and there are doubtless others) but this seems good enough to checkin.

src/coreclr/vm/methoditer.cpp Show resolved Hide resolved
src/coreclr/debug/daccess/dacdbiimpl.cpp Show resolved Hide resolved
@build-analysis build-analysis bot mentioned this pull request Jan 31, 2024
Closed
@elinor-fung elinor-fung merged commit 36287c2 into dotnet:main Jan 31, 2024
108 of 111 checks passed
@elinor-fung elinor-fung deleted the removeUnrestored branch January 31, 2024 22:52
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidwrighton davidwrighton davidwrighton approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees

@elinor-fung elinor-fung

Labels
area-VM-coreclr
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@elinor-fung @davidwrighton @AaronRobinsonMSFT