Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update latest roslyn version to 4.8 #97767

Merged
merged 6 commits into from
Jan 31, 2024
Merged

Update latest roslyn version to 4.8 #97767

merged 6 commits into from
Jan 31, 2024

Conversation

DoctorKrolic
Copy link
Contributor

This is required to use new language features like collection expressions e.g. in #96964

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jan 31, 2024
@ViktorHofer
Copy link
Member

I approved this but it's @jkoritzinsky who introduced these properties. Jeremy, PTAL.

eng/Versions.props Outdated Show resolved Hide resolved
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
@jkoritzinsky
Copy link
Member

We're going to need to update the sourcebuild baseline. Can you update this line to refer to 4.8?

<UsagePattern IdentityGlob="Microsoft.CodeAnalysis*/*4.7.*" />

@DoctorKrolic
Copy link
Contributor Author

I thought this would be easier... @jkoritzinsky PTAL

Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkoritzinsky
Copy link
Member

Failures are all known.

@jkoritzinsky jkoritzinsky merged commit 7410954 into dotnet:main Jan 31, 2024
182 of 188 checks passed
@DoctorKrolic DoctorKrolic deleted the update-code-analysis-version branch February 1, 2024 07:03
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-crossgen2-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants