Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with Android 26 NDK (which has some nullability annotations) #97976

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

filipnavara
Copy link
Member

No description provided.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 5, 2024
@ghost
Copy link

ghost commented Feb 5, 2024

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: filipnavara
Assignees: -
Labels:

area-System.Net, community-contribution

Milestone: -

Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MichalStrehovsky
Copy link
Member

Close/reopen to retrigger CI. Lots of legs were failing due to some network issue.

@filipnavara
Copy link
Member Author

Test failures seem unrelated - WASM is "500 Internal Server Error", rest is #97049.

@ghost
Copy link

ghost commented Feb 12, 2024

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: filipnavara
Assignees: -
Labels:

area-System.Net, os-android, community-contribution

Milestone: -

@akoeplinger akoeplinger merged commit be5c2a2 into dotnet:main Feb 12, 2024
132 of 137 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
@karelz karelz added this to the 9.0.0 milestone May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net community-contribution Indicates that the PR has been added by a community member os-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants