-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TryParseBigIntegerHexOrBinaryNumberStyle #97995
Conversation
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsSince the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Is there an explicit test we can add to cover this?
I think the test for values whose absolute value is greater than 0x7FFFFFFF and less than 0x100000000 can cover this.
|
I'd like to add tests for non-edge cases that fall into this branch, both even and odd numbers. Thank you again for discovering these! I'm really busy to complete things recently. |
Since the
-
operator has higher precedence than the^
operator,leading ^ signBits - signBits
is always equal toleading
.Related #95543