Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some linux-arm test coverage #98022

Merged
merged 8 commits into from
Feb 22, 2024
Merged

Add some linux-arm test coverage #98022

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
08bd2e9
Add some linux-arm and linux-musl-arm test coverage
MichalStrehovsky Feb 6, 2024
fce4df5
Update runtime-nativeaot-outerloop.yml
MichalStrehovsky Feb 6, 2024
30d0ad3
Update runtime-nativeaot-outerloop.yml
MichalStrehovsky Feb 14, 2024
a9fdb14
Add exclusions for failing NativeAOT/arm32 tests
filipnavara Feb 15, 2024
a59f0c9
Update issues.targets
MichalStrehovsky Feb 20, 2024
d932449
Merge branch 'main' into MichalStrehovsky-patch-1
MichalStrehovsky Feb 20, 2024
68091c3
Update issues.targets
MichalStrehovsky Feb 22, 2024
3554791
Update tests.proj
MichalStrehovsky Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,17 @@ extends:
- osx_x64
- osx_arm64
- linux_x64
- linux_arm
- linux_arm64
- linux_musl_x64
- linux_musl_arm64
jobParameters:
testGroup: innerloop
isSingleFile: true
nameSuffix: NativeAOT_Libs
buildArgs: -s clr.aot+host.native+libs+libs.tests -c $(_BuildConfig) /p:TestNativeAot=true /p:ArchiveTests=true /p:IlcUseServerGc=false
timeoutInMinutes: 300 # doesn't normally take this long, but I've seen Helix queues backed up for 160 minutes
includeAllPlatforms: true
# extra steps, run tests
postBuildSteps:
- template: /eng/pipelines/libraries/helix.yml
Expand Down Expand Up @@ -162,6 +165,7 @@ extends:
platforms:
- windows_x64
- linux_x64
- linux_arm
variables:
- name: timeoutPerTestInMinutes
value: 60
Expand Down
10 changes: 10 additions & 0 deletions src/tests/issues.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1166,6 +1166,16 @@
</ExcludeList>
</ItemGroup>

<!-- NativeAOT arm32 specific excludes -->
<ItemGroup Condition="'$(XunitTestBinBase)' != '' and '$(TestBuildMode)' == 'nativeaot' and '$(RuntimeFlavor)' == 'coreclr' and ('$(TargetArchitecture)' == 'arm' or '$(AltJitArch)' == 'arm')">
<ExcludeList Include="$(XunitTestBinBase)/Loader/classloader/Casting/punning*">
<Issue>https://github.com/dotnet/runtime/issues/98493</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/JIT/Directed/nullabletypes/Desktop/boxunboxvaluetype_*">
<Issue>https://github.com/dotnet/runtime/issues/95517</Issue>
</ExcludeList>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like I made some mistake and the exclusions don't work as intended. :-/

I submitted a fix for the second one (#98547).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...and for the first one (#98561). Although I very much doubt it will go through without scrutiny from the JIT team.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the exclusions and do another test run :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I submitted a fix for the second one (#98547).

#98547 fix is not correct as discovered in #98623 (comment) . I expect that the test will keep failing.

Also, there may be unforeseen perf issues due to #98623 (comment) . I am thinking that we should revert it and wait for the proper fix from @EgorBo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect that the test will keep failing.

The test doesn’t fail. I checked that locally before submitting the fix. However, it doesn’t fail because the size of the block is small enough to take the managed code path which happens to trigger NRE correctly. It would still fail for big sizes but that’s not the case in the tested unboxing scenario.

</ItemGroup>

<!-- run.proj finds all the *.cmd/*.sh scripts in a test folder and creates corresponding test methods.
Exclude these scripts to avoid creating such methods for the superpmicollect dependent test projects
and running them separately from superpmicollect test. These should be excluded regardless of RuntimeFlavor/os/arch-->
Expand Down
Loading