Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bionic docs #98088

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Update Bionic docs #98088

merged 3 commits into from
Feb 8, 2024

Conversation

MichalStrehovsky
Copy link
Member

Cc @dotnet/ilc-contrib

@ghost
Copy link

ghost commented Feb 7, 2024

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Cc @dotnet/ilc-contrib

Author: MichalStrehovsky
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

@ghost ghost assigned MichalStrehovsky Feb 7, 2024
To build for Bionic:

* Ensure you have [Android NDK](https://developer.android.com/ndk/downloads) for your system downloaded and extracted somewhere. We build and test with NDK r23c but anything newer should also work. Double check with the NDK version referenced [here](https://github.com/dotnet/runtime/blob/main/docs/workflow/testing/libraries/testing-android.md), which might be more up-to-date than this document.
* Ensure you have [Android NDK](https://developer.android.com/ndk/downloads) for your system downloaded and extracted somewhere. We build and test with NDK r23c but anything newer should also work. Newer releases of the NDK might require a workaround (https://github.com/dotnet/runtime/issues/92272). Double check with the NDK version referenced [here](https://github.com/dotnet/runtime/blob/main/docs/workflow/testing/libraries/testing-android.md), which might be more up-to-date than this document.
Copy link
Member

@jkotas jkotas Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People going through these steps won't be able to tell whether they need the workaround or not at this point. Instead of this, we may want to mention this after the publish step. Something like:

If you see error : version script assignment of 'V1.0' to symbol '_init' failed: symbol not defined error, add these lines to your .csproj to workaround a known issue with certain NDK versions:

<ItemGroup Condition="'$(RuntimeIdentifier)' == 'linux-bionic'">
  <LinkerArg Include="-Wl,--defsym,_init=__libc_init" />
  <LinkerArg Include="-Wl,--defsym,_fini=__libc_fini" />
</ItemGroup

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the workaround be integrated into the SDK so that it's applied automatically?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the workaround be integrated into the SDK so that it's applied automatically?

Yes, we can backport the fix once the issue is fixed...

@MichalStrehovsky MichalStrehovsky merged commit de1d1a0 into main Feb 8, 2024
12 checks passed
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-3 branch February 8, 2024 12:37
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants