Propagate installers in runtime output in VMR build #98104
Conversation
Also, rename SourceBuild.props to DotNetBuild.props to reflect its purpose.
ghost
assigned 
dotnet-issue-labeler
bot
added
the
needs-area-label
|
Testing this in a full VMR build right now. |
| @@ -92,6 +91,15 @@ | |||
| Include="$(CurrentRepoSourceBuildArtifactsPackagesDir)Shipping\dotnet-crossgen2-*$(ArchiveExtension)" | |||
| Category="Crossgen2Archive" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Condition="'$(DotNetBuildOrchestrator)' == 'true'"> | |||
There was a problem hiding this comment.
So I'm still confused. Why do we need this condition?
There was a problem hiding this comment.
Why can't we use DotNetBuild?
There was a problem hiding this comment.
We don't want to accidentally include these in the intermediate nupkgs that are necessary for source-build repo legs. I don't think that they're actually produced for those legs, but this is to make sure. If we do, include a .deb for instance, we might hit the AzDO package size limit.
They're only necessary when installer (and probably consumes) upstream installers for building its own installers.
There was a problem hiding this comment.
The reason you can't use DotNetBuild is that it's active in a repo-only build.
Also, rename SourceBuild.props to DotNetBuild.props to reflect its purpose.