Report unhandled exceptions/FailFast in event log #98152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#73998. `EventReporter` is basically taken from eventreporter.cpp in the VM.
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsFixes #73998.
Cc @tommcdon @mikem8361 @dotnet/ilc-contrib
|
ghost
assigned 
Suchiman
reviewed
Feb 8, 2024
| _description.AppendLine("unknown"); | ||
| } | ||
|
|
||
| _description.Append("CoreCLR Version: "); |
There was a problem hiding this comment.
CoreCLR?
Don't see a good enough reason to break people who parse this.
jkotas
reviewed
Feb 8, 2024
src/coreclr/nativeaot/System.Private.CoreLib/src/System/EventReporter.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Feb 8, 2024
| if (exception != null && reason is not RhFailFastReason.AssertionFailure) | ||
| { | ||
| reporter.AddDescription($"{exception.GetType()}: {exception.Message}"); | ||
| reporter.AddStackTrace(exception.StackTrace); |
There was a problem hiding this comment.
Computing the stack trace is a complicated operation and it is likely to crash again when things are corrupted. The existing console printing code is written in a way so that there is at least something printed to the console in this case, giving people clue what might have happened.
There was a problem hiding this comment.
Moved it after writing to console.
jkotas
reviewed
Feb 8, 2024
src/coreclr/vm/eventreporter.h
Outdated
Comment on lines
18
to
20
| // Maximum size for a string in event log entry | ||
| #define MAX_SIZE_EVENTLOG_ENTRY_STRING 0x8000 // decimal 32768 | ||
|
|
There was a problem hiding this comment.
Suggested change
| // Maximum size for a string in event log entry | |
| #define MAX_SIZE_EVENTLOG_ENTRY_STRING 0x8000 // decimal 32768 |
jkotas
reviewed
Feb 8, 2024
src/coreclr/vm/eventreporter.h
Outdated
| // permissible length of the string and event header became 32K, resulting in strings becoming | ||
| // shorter in length. Hence, the change in size. | ||
| // An event entry comprises of string to be written and event header information. | ||
| // The total permissible length of the string and event header is 32K. | ||
| #define MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA 0x7C62 // decimal 31842 |
There was a problem hiding this comment.
Suggested change
| #define MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA 0x7C62 // decimal 31842 | |
| #define MAX_SIZE_EVENTLOG_ENTRY_STRING 0x7C62 // decimal 31842 |
jkotas
reviewed
Feb 8, 2024
Comment on lines
91
to
107
| const int MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA = 0x7C62; // decimal 31842 | ||
|
|
||
| // Continue to append to the buffer until we are full | ||
| if (!_bufferFull) | ||
| { | ||
| _description.AppendLine(s); | ||
|
|
||
| // Truncate the buffer if we have exceeded the limit based upon the OS we are on | ||
| if (_description.Length > MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA) | ||
| { | ||
| // Load the truncation message | ||
| string truncate = "\nThe remainder of the message was truncated.\n"; | ||
|
|
||
| int truncCount = truncate.Length; | ||
|
|
||
| // Go back "truncCount" characters from the end of the string. | ||
| int ext = MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA - truncCount; |
There was a problem hiding this comment.
Suggested change
| const int MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA = 0x7C62; // decimal 31842 | |
| // Continue to append to the buffer until we are full | |
| if (!_bufferFull) | |
| { | |
| _description.AppendLine(s); | |
| // Truncate the buffer if we have exceeded the limit based upon the OS we are on | |
| if (_description.Length > MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA) | |
| { | |
| // Load the truncation message | |
| string truncate = "\nThe remainder of the message was truncated.\n"; | |
| int truncCount = truncate.Length; | |
| // Go back "truncCount" characters from the end of the string. | |
| int ext = MAX_SIZE_EVENTLOG_ENTRY_STRING_WINVISTA - truncCount; | |
| const int MAX_SIZE_EVENTLOG_ENTRY_STRING = 0x7C62; // decimal 31842 | |
| // Continue to append to the buffer until we are full | |
| if (!_bufferFull) | |
| { | |
| _description.AppendLine(s); | |
| // Truncate the buffer if we have exceeded the limit based upon the OS we are on | |
| if (_description.Length > MAX_SIZE_EVENTLOG_ENTRY_STRING) | |
| { | |
| // Load the truncation message | |
| string truncate = "\nThe remainder of the message was truncated.\n"; | |
| int truncCount = truncate.Length; | |
| // Go back "truncCount" characters from the end of the string. | |
| int ext = MAX_SIZE_EVENTLOG_ENTRY_STRING - truncCount; |
|
cc @Hoyos @mikem8361 |
This was referenced Feb 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73998.
EventReporteris basically taken from eventreporter.cpp in the VM.Cc @tommcdon @mikem8361 @dotnet/ilc-contrib