Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ILLink] Add interface implementing type to OverrideInformation and use where it makes sense #98274

Merged
merged 20 commits into from
Feb 29, 2024
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
8454427
Refactor OverrideInformation to include interface implementing type
jtschuster Feb 11, 2024
54c326d
Add NotNullWhenAttribute for InterfaceImplementor
jtschuster Feb 11, 2024
6bfc58a
Don't allow null interfaceImpl when base and override are interface m…
jtschuster Feb 11, 2024
ecc5d0c
Add InterfaceType to InterfaceImplementor
jtschuster Feb 11, 2024
310de30
Make new members internal for compat warnings
jtschuster Feb 13, 2024
77195a3
Make InterfaceImplementor internal for API compat
jtschuster Feb 14, 2024
a73cc1f
Make TypeMapInfo internal for API Compat
jtschuster Feb 14, 2024
76bc255
Add InterfaceImplementor to suppressions.xml
jtschuster Feb 14, 2024
11577fa
Make types public again
jtschuster Feb 14, 2024
5fb3256
Use correct InterfaceImplementor in FindAndAddDims
jtschuster Feb 15, 2024
3b4a69d
InterfaceImplementor doesn't need to directly implement the interface
jtschuster Feb 15, 2024
14814ed
PR Feedback
jtschuster Feb 21, 2024
56f23e4
Don't need to resolve TypeDefinitions
jtschuster Feb 21, 2024
ccd0a8f
Merge branch 'main' of https://github.com/dotnet/runtime into CheckIm…
jtschuster Feb 22, 2024
1d1e883
Use correct InterfaceImpl
jtschuster Feb 22, 2024
7b218b6
Add argument to first call
jtschuster Feb 22, 2024
9addd27
Merge branch 'main' of https://github.com/dotnet/runtime into CheckIm…
jtschuster Feb 23, 2024
81ebc93
Look on base types and interfaces for interfaceImpl
jtschuster Feb 23, 2024
2110159
Add test case and invert if
jtschuster Feb 28, 2024
488ff72
PR feedback:
jtschuster Feb 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add InterfaceImplementor to suppressions.xml
  • Loading branch information
jtschuster committed Feb 14, 2024
commit 76bc2554b2062c381e23772faa388c851ec08c83
4 changes: 4 additions & 0 deletions src/tools/illink/src/linker/CompatibilitySuppressions.xml
Original file line number Diff line number Diff line change
@@ -253,6 +253,10 @@
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.ILogger</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.InterfaceImplementor</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.InternalErrorException</Target>