Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: isinst(cls, null) -> null #98284

Merged
merged 1 commit into from
Feb 12, 2024
Merged

JIT: isinst(cls, null) -> null #98284

merged 1 commit into from
Feb 12, 2024

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Feb 11, 2024 •
edited
Loading

@ghost ghost assigned EgorBo Feb 11, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 11, 2024
@ghost
Copy link

ghost commented Feb 11, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: EgorBo
Assignees: EgorBo
Labels:

area-CodeGen-coreclr
Milestone: -

This was referenced Feb 12, 2024
Closed
Closed
@EgorBo EgorBo marked this pull request as ready for review February 12, 2024 02:49
@EgorBo
Copy link
Member Author

EgorBo commented Feb 12, 2024

PTAL @jakobbotsch @dotnet/jit-contrib
Simple change, folds "null is Foo" into null (via VN).

@EgorBo EgorBo merged commit 33e6c90 into dotnet:main Feb 12, 2024
127 of 129 checks passed
@EgorBo EgorBo deleted the vn-isinst branch February 12, 2024 13:05
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EgorBo @jakobbotsch