Partial revert "Enable native AOT for non-portable crossgen2 (#97536)" #98303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
ViktorHofer
reviewed
Feb 12, 2024
| @@ -20,6 +20,8 @@ | |||
| <ShouldVerifyClosure>false</ShouldVerifyClosure> | |||
| <!-- Publish crossgen2 as a single-file app on native-OS builds. Cross-OS NativeAOT compilation is not supported yet --> | |||
| <NativeAotSupported Condition="'$(CrossBuild)' == 'true' and '$(TargetOS)' != '$(HostOS)'">false</NativeAotSupported> | |||
| <!-- Can't use NativeAOT in source build yet https://github.com/dotnet/runtime/issues/66859 --> | |||
| <NativeAotSupported Condition="'$(DotNetBuildFromSource)' == 'true'">false</NativeAotSupported> | |||
There was a problem hiding this comment.
Should we condition this on PortableBuild != true same as in crossgen2_publish?
There was a problem hiding this comment.
This is a simple revert to the previous state. I do not want to be fixing it to avoid introducing more build breaks.
We want to get rid of this line anyway.
There was a problem hiding this comment.
(This is reverting #97536.)
ViktorHofer
approved these changes
Feb 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#4111 (comment)