Fix debug info emitted for VLT_STK_REG/VLT_FPSTK variable locations #98479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue Detailsnull
|
filipnavara
changed the title
filipnavara
added
the
community-contribution
16 tasks
Comment on lines
+539
to
+541
| // On ARM32 this is used to encode actual registers. This may be wrong for x86 | ||
| // which we don't support anyway. | ||
| e.OpReg(loc.B); |
There was a problem hiding this comment.
I would expect this to be correct on x86 as well - the Jit never places anything but the return value on the actual FPU stack.
TIHan
approved these changes
Feb 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.