Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][MT] cleanup #98672

Merged
merged 22 commits into from
Feb 21, 2024
Merged

[browser][MT] cleanup #98672

merged 22 commits into from
Feb 21, 2024

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Feb 19, 2024 •
edited
Loading

  • rename set_arg_bool, get_arg_bool and fix type to setB32 and getB32
  • simplified browser-threads sample
  • fix Debug wrapper functions
  • fix MT memory leak with is_receiver_should_free
  • disable AggressiveInlining in DEBUG
  • fix size for the alloc_stack_frame
  • set_arg_proxy_context when marshaling null to C#
  • renamed isManagedRunningOnCurrentThread
  • added runtimeHelpers.currentThreadTID
  • fix __emscripten_thread_init wrapper

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Feb 19, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Feb 19, 2024
@pavelsavara pavelsavara requested a review from maraf February 19, 2024 18:27
@pavelsavara pavelsavara requested a review from lewing as a code owner February 19, 2024 18:27
@ghost
Copy link

ghost commented Feb 19, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: pavelsavara
Assignees: -
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 9.0.0

@ghost ghost assigned pavelsavara Feb 19, 2024
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Feb 20, 2024
Closed
pavelsavara and others added 6 commits February 20, 2024 11:14
@pavelsavara @maraf
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
df9a2ef 
…stem/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs

Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
279b8b2 
…stem/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs

Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
795d479 
…stem/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs

Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
9cf90ed 
…stem/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs

Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
0bfe8b0 
…stem/Runtime/InteropServices/JavaScript/JSMarshalerArgument.cs

Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara
Merge branch 'main' into browser_cleanup2
b7679d7
This was referenced Feb 20, 2024
Closed
Closed
Closed
Closed
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Feb 21, 2024
Closed
Closed
@pavelsavara
Copy link
Member Author

created active issue #98758

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara merged commit 32929b6 into dotnet:main Feb 21, 2024
136 of 138 checks passed
@pavelsavara pavelsavara deleted the browser_cleanup2 branch February 21, 2024 16:15
@build-analysis build-analysis bot mentioned this pull request Feb 21, 2024
Closed
@pavelsavara pavelsavara mentioned this pull request Mar 10, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilonatommy ilonatommy ilonatommy left review comments

@maraf maraf maraf approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelsavara @maraf @ilonatommy