Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle MakeGeneric APIs in dataflow #99037

Merged
merged 6 commits into from
Mar 6, 2024

Handle MakeGeneric APIs in dataflow

f93fd06
Select commit
Loading
Failed to load commit list.
Merged

Handle MakeGeneric APIs in dataflow #99037

Handle MakeGeneric APIs in dataflow
f93fd06
Select commit
Loading
Failed to load commit list.
Azure Pipelines / dotnet-linker-tests (Build linux-x64 release Runtime_Release) failed Feb 28, 2024 in 16m 7s

Build linux-x64 release Runtime_Release failed

Annotations

Check failure on line 1079 in src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/ReflectionMethodBodyScanner.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dotnet-linker-tests (Build linux-x64 release Runtime_Release)

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/ReflectionMethodBodyScanner.cs#L1079

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/ReflectionMethodBodyScanner.cs(1079,23): error CA1852: (NETCORE_ENGINEERING_TELEMETRY=Build) Type 'MakeGenericTypeSite' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)

Check failure on line 1065 in src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/ReflectionMethodBodyScanner.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dotnet-linker-tests (Build linux-x64 release Runtime_Release)

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/ReflectionMethodBodyScanner.cs#L1065

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/ReflectionMethodBodyScanner.cs(1065,23): error CA1852: (NETCORE_ENGINEERING_TELEMETRY=Build) Type 'MakeGenericMethodSite' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)