Fix typo in TryExpandTypeEquality

[jkotas]

Fixes #99047

[ghost]

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #99047

Author:	jkotas
Assignees:	-
Labels:	area-NativeAOT-coreclr
Milestone:	-

[MichalStrehovsky]

Was about to PR this myself :)

[jkotas]

This typo has been harmless most of the time since the next check in the sequence is going to immediately going to fail anyway. The offending method in Microsoft.AspNetCore.Identity.EntityFrameworkCore contains a specific sequence of bytes that passed the next check in the sequence and eventually fail with InvalidProgramException.

[MichalStrehovsky]

This typo has been harmless most of the time since the next check in the sequence is going to immediately going to fail anyway. The offending method in Microsoft.AspNetCore.Identity.EntityFrameworkCore contains a specific sequence of bytes that passed the next check in the sequence and eventually fail with InvalidProgramException.

Yeah, I also didn't see a repro with .NET 9 so this needs to have quite some bad luck to get hit. I wasn't intending to write a regression test either.

[MichalStrehovsky]

One thing I was thinking about is whether we'd want to put this substitution logic under a try/catch (TypeLoaderException) (and just use original IL if it throws). This would avoid compilation failure for a bug like this. Not sure if it's an overall improvement though.

[jkotas]

This would avoid compilation failure for a bug like this. Not sure if it's an overall improvement though.

Yeah, the downside is that the bug like this would be hidden, and it would be unlikely for it to be reported.