-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set scope and build validation in dev when no options provided #99199
Merged
+34
−0
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1582743
set scope and build validation in dev when no options provided
wcsanders1 d47722f
Merge branch 'main' into issue-97091
wcsanders1 a57ab71
Merge branch 'main' into issue-97091
wcsanders1 81ce220
Merge branch 'main' into issue-97091
wcsanders1 8651c0a
Merge branch 'main' into issue-97091
wcsanders1 47a7487
Merge branch 'main' into issue-97091
wcsanders1 41e5b4a
Merge branch 'main' into issue-97091
wcsanders1 7649ad3
Merge branch 'main' into issue-97091
wcsanders1 4ea7d0e
Merge branch 'main' into issue-97091
wcsanders1 4a4d5b8
Merge branch 'main' into issue-97091
wcsanders1 9e9e299
Merge branch 'main' into issue-97091
wcsanders1 b087b83
Merge branch 'main' into issue-97091
wcsanders1 1861eb3
make default provider field nonnullable
wcsanders1 b7edfa7
Merge branch 'main' into issue-97091
wcsanders1 4dc5140
Merge branch 'main' into issue-97091
wcsanders1 1e089c6
Merge branch 'main' into issue-97091
wcsanders1 c1a7edf
Merge branch 'main' into issue-97091
wcsanders1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this ever set to false? Should that be done in
UseServiceProviderFactory
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it seems to me that this field should be set to false when
UseServiceProviderFactory
is called. This was my oversight I believe.