Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip EventSource tests if process is not elevated #99261

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

davmason
Copy link
Member

@davmason davmason commented Mar 4, 2024

Fixes #88305

No reason to fail the test if the issue is in the machine setup.

@davmason davmason added this to the 9.0.0 milestone Mar 4, 2024
@davmason davmason requested a review from a team March 4, 2024 20:33
@davmason davmason self-assigned this Mar 4, 2024
@ghost
Copy link

ghost commented Mar 4, 2024

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #88305

No reason to fail the test if the issue is in the machine setup.

Author: davmason
Assignees: davmason
Labels:

area-System.Diagnostics.Tracing

Milestone: 9.0.0

@hoyosjs
Copy link
Member

hoyosjs commented Mar 5, 2024

My concern is now, will we ever get test coverage?

@davmason
Copy link
Member Author

davmason commented Mar 5, 2024

The failure is intermittent so I think we will still have coverage

@davmason davmason merged commit f84d33c into dotnet:main Mar 5, 2024
109 of 111 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure BasicEventSourceTests.TestsWrite.Test_Write_T_ETW
2 participants