Fix InlineArray and some other corner cases in Swift lowering #99337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sure we have correct inlinearray support and fix unaligned lowering calculations
ghost
assigned 
jkoritzinsky
changed the title
jakobbotsch
previously approved these changes
Mar 6, 2024
jakobbotsch
reviewed
Mar 6, 2024
The following algorithm changes were made: - Don't merge an Opaque interval and and Empty interval during construction. - Introduce a post-processing phase that removes Empty intervals and merges Opaque intervals that used to have Empty intervals between them, as long as the opaque intervals are within the same pointer-size block. - Use the opaque interval's offset and size when breaking it up. - Allow the opaque splitting to split up higher sizes if the lower sizes have improved the alignment.
|
Do we want to check in all the tests, or should we reduce them to a smaller set once everything is passing (perhaps making sure we include the specific cases that were investigated)? I wasn't planning on checking all my tests in in #99294 since it seems like a lot of source code to commit. |
|
Yeah I'm going to go back and slim down the test list to have a few representative samples of the failures. |
Update tests that need to specify non-natural offsets to specify them. Reduce Swift test suite to a representative sample of the various cases that have captured failures.
jakobbotsch
approved these changes
Mar 7, 2024
42 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the case mentioned in #99294 (comment)
Fixes InlineArray support