[release/8.0-staging] [mono] Set /DEBUGTYPE:CV,FIXUP on Windows binaries #99356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This fixes an issue with running APIScan on mono-aot-cross.exe
jeffschwMSFT
approved these changes
Mar 6, 2024
lewing
approved these changes
Mar 6, 2024
|
Tell mode, applying servicing-approved. |
akoeplinger
added
Servicing-approved
This was referenced Mar 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #99282 to release/8.0-staging
/cc @akoeplinger
Customer Impact
This is necessary so mono-aot-cross.exe can be scanned by APIScan which needs these flags to correctly analyze .pdb symbols: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1954385
Regression
Testing
Manually tested with APIScan tooling.
Risk
Low, this is just changing some compiler flags that are already used by other parts of the build.