-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser][MT] dedicated io thread #99422
Conversation
da607d0
to
738be39
Compare
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
1e0c0b2
to
2bfe57a
Compare
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
we have deadlock in
This is exactly the scenario that this PR should solve. It's synchronous Wait on
|
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
7020bf6
to
3e80e32
Compare
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing change in dotnet.d.ts
. Most of the comments are nits
...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Show resolved
Hide resolved
...vices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSHostImplementation.Types.cs
Show resolved
Hide resolved
...aScript/src/System/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs
Outdated
Show resolved
Hide resolved
...aScript/src/System/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs
Outdated
Show resolved
Hide resolved
...aScript/src/System/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs
Outdated
Show resolved
Hide resolved
…stem/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs Co-authored-by: Marek Fišera <mara@neptuo.com>
…stem/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs Co-authored-by: Marek Fišera <mara@neptuo.com>
…stem/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs Co-authored-by: Marek Fišera <mara@neptuo.com>
…stem/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs Co-authored-by: Marek Fišera <mara@neptuo.com>
…stem/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs Co-authored-by: Marek Fišera <mara@neptuo.com>
…stem/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs Co-authored-by: Marek Fišera <mara@neptuo.com>
Co-authored-by: Marek Fišera <mara@neptuo.com>
.Wait
on deputy thread in async methods, async JSExport, C#Main()
changes
BeforeSyncJSExport
andAfterSyncJSExport
also onJSWebWorker
(same thread)ConfigureAwait(true)
in HTTP clientmono_wasm_print_thread_dump
toINTERNAL
tests
WaitDoesNotAssertInAsyncCode
<-- this is why we do this!WaitAssertsOnSyncCallback
WaitAssertsOnSyncJSExport
System.Runtime.InteropServices.JavaScript.BackgroundExec.Tests
new active issues