Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RISC-V] Enable crossgen for corelib #99436

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Conversation

clamp03
Copy link
Member

@clamp03 clamp03 commented Mar 8, 2024

This enables crossgen2 for corelib because

  • We fixed many bugs on crossgen2. I think crossgen2 is enough for corelib.
  • To prevent breaks on RISC-V, I want to add a checker in RISC-V build CI.

Actually, there are still some bugs like #97877, but I beleive that we can fix them soon.
+ To run with crossgened files on RISC-V, we need to disable EnableWriteXorExecute. (DOTNET_EnableWriteXorExecute=0)

Part of #84834
cc @dotnet/samsung

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 8, 2024
@clamp03 clamp03 self-assigned this Mar 8, 2024
@clamp03 clamp03 added the arch-riscv Related to the RISC-V architecture label Mar 8, 2024
@jkotas jkotas merged commit bfd5729 into dotnet:main Mar 8, 2024
110 checks passed
@clamp03
Copy link
Member Author

clamp03 commented Mar 8, 2024

@gbalykov IMO, the internal RISC-V CI will fail due to this PR. Please update the CI. Thank you!

@gbalykov
Copy link
Member

gbalykov commented Mar 8, 2024

@clamp03 thanks, let's see how it goes for a couple of days during the weekend and I'll check on Monday

@clamp03 clamp03 deleted the enablecrossgenspc branch March 8, 2024 10:52
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-riscv Related to the RISC-V architecture area-crossgen2-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants