Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][jit] Optimize JIT time on platforms without SIMD support. #99485

Merged
merged 1 commit into from
Mar 11, 2024
Merged

[mono][jit] Optimize JIT time on platforms without SIMD support. #99485

merged 1 commit into from
Mar 11, 2024

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Mar 9, 2024

  • Move the if (cfg->opt & MONO_OPT_SIMD) checks into simd-intrinsics.c so the IsSupported checks can be intrinsified even if SIMD is disabled.
  • Implement mono_simd_unsupported_aggressive_inline_intrinsic_type () in the non-simd cases as well, add more types.

Re: #97295.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @SamMonoRT, @vargaz
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Mar 9, 2024
Closed
@vargaz
[mono][jit] Optimize JIT time on platforms without SIMD support.
502cfb3 
* Move the if (cfg->opt & MONO_OPT_SIMD) checks into simd-intrinsics.c
  so the IsSupported checks can be intrinsified even if SIMD is disabled.
* Implement mono_simd_unsupported_aggressive_inline_intrinsic_type () in
  the non-simd cases as well, add more types.

Re: dotnet#97295.
@build-analysis build-analysis bot mentioned this pull request Mar 10, 2024
Closed
fanyang-mono
fanyang-mono approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@fanyang-mono fanyang-mono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vargaz vargaz merged commit fd2f2a7 into dotnet:main Mar 11, 2024
109 of 111 checks passed
@vargaz vargaz deleted the no-simd-opt branch March 11, 2024 20:42
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fanyang-mono fanyang-mono fanyang-mono approved these changes

@lambdageek lambdageek Awaiting requested review from lambdageek

@steveisok steveisok Awaiting requested review from steveisok steveisok is a code owner

Assignees

@vargaz vargaz

Labels
area-Codegen-JIT-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vargaz @fanyang-mono