Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mt][browser] Prevent SignalRClientTests fail with "PlaywrightException: Target closed" #99537

Merged
merged 7 commits into from
Mar 15, 2024

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Mar 11, 2024

Fixes #99483.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-VM-threading-mono labels Mar 11, 2024
@ilonatommy ilonatommy self-assigned this Mar 11, 2024
@ilonatommy ilonatommy marked this pull request as ready for review March 12, 2024 14:53
@ilonatommy ilonatommy requested a review from maraf as a code owner March 12, 2024 14:53
@ilonatommy ilonatommy requested review from pavelsavara and maraf and removed request for maraf March 12, 2024 14:53
Copy link
Member

@pavelsavara pavelsavara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert eng/testing/scenarios/BuildWasmAppsJobsList.txt

@ilonatommy
Copy link
Member Author

please revert eng/testing/scenarios/BuildWasmAppsJobsList.txt

Will do. But on the last (3rd) run the test hit the problem again, so it's not a fix. Will try with just a delay you proposed.

ilonatommy and others added 2 commits March 13, 2024 13:37
@ilonatommy ilonatommy merged commit b6585cc into main Mar 15, 2024
22 checks passed
@jkotas jkotas deleted the fix-99483 branch March 15, 2024 23:36
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-VM-threading-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SignalRClientTests fail with "PlaywrightException: Target closed"
3 participants