Use release config for Mono tests #99920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This preserves prior behavior and fixes the timeout issues we're seeing
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
carlossanlop
approved these changes
Mar 18, 2024
| @@ -1772,7 +1772,7 @@ extends: | |||
| jobParameters: | |||
| testGroup: innerloop | |||
| nameSuffix: Mono_Interpreter_LibrariesTests | |||
| buildArgs: -s mono+libs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true | |||
| buildArgs: -s mono+libs+libs.tests -rc Release -c $(_BuildConfig) /p:ArchiveTests=true | |||
There was a problem hiding this comment.
I see, you're still giving the option of choosing the -c for the runtime, even though -rc assumes Debug on libraries. They don't collide with each other, right?
There was a problem hiding this comment.
Yeah this works fine. I generally prefer the explicitness of passing -c always in case we want to change it. It's not necessary here, just preference of explicitness (like the rest of the pipelines).
ViktorHofer
approved these changes
Mar 18, 2024
steveisok
approved these changes
Mar 18, 2024
ivdiazsa
approved these changes
Mar 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This preserves prior behavior and fixes the timeout issues we're seeing