Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to using the new Roslyn IIncrementalGenerator API for better in-VS performance #1374

Merged
merged 31 commits into from
Sep 8, 2021
Merged

Move to using the new Roslyn IIncrementalGenerator API for better in-VS performance #1374

merged 31 commits into from
Sep 8, 2021

Commits on May 25, 2021

  1. First pass converting to V2 API.

    @jkoritzinsky
    jkoritzinsky committed May 25, 2021
    Configuration menu
    Copy the full SHA
    d11a4f9 View commit details
    Browse the repository at this point in the history

  2. Use the WrapGenerator API to enable more scenarios for testing.

    @jkoritzinsky
    jkoritzinsky committed May 25, 2021
    Configuration menu
    Copy the full SHA
    7be13c3 View commit details
    Browse the repository at this point in the history

  3. Add one more early filter for now.

    @jkoritzinsky
    jkoritzinsky committed May 25, 2021
    Configuration menu
    Copy the full SHA
    781eea1 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2021

  1. Merge branch 'feature/DllImportGenerator' into incremental-generator

    @jkoritzinsky
    jkoritzinsky committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    d45efe9 View commit details
    Browse the repository at this point in the history

  2. Update incremental generators to approved API.

    @jkoritzinsky
    jkoritzinsky committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    0ea9933 View commit details
    Browse the repository at this point in the history

  3. Fix unsupported TFM diagnostics.

    @jkoritzinsky
    jkoritzinsky committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    4d3581a View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Use our own custom objects for representing types at the TypePosition… 

    …Info level instead of using symbols. This way, we can use the default comparer between TypePositionInfo instances to know if they're identical, even across compilations.
    @jkoritzinsky
    jkoritzinsky committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    44fc621 View commit details
    Browse the repository at this point in the history

  2. Add TypePositionInfo record constructor and simplify the API.

    @jkoritzinsky
    jkoritzinsky committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    e1226d2 View commit details
    Browse the repository at this point in the history

  3. Build out some infrastructure for testing incrementality of the sourc… 

    …e generator and write one test.
    @jkoritzinsky
    jkoritzinsky committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    ee8f2ea View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/DllImportGenerator' into incremental-generator

    @jkoritzinsky
    jkoritzinsky committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    447ab47 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2021

  1. Refactor TypePositionInfo/MarshallingGenerator creation into a separa… 

    …te step so syntax generation only happens incrementally
    @jkoritzinsky
    jkoritzinsky committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    02ba8ae View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2021

  1. Refactor comparers. Update to public Roslyn build + API changes. Add … 

    …more incremental tests and stub out some that should theoretially work, but we can't actually test since GeneratorDriver doesn't support incrementality in the right way.
    @jkoritzinsky
    jkoritzinsky committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    a38ced3 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2021

  1. Refactor comparers. Update to public Roslyn build + API changes. Add … 

    …more incremental tests and stub out some that should theoretially work, but we can't actually test since GeneratorDriver doesn't support incrementality in the right way.
    @jkoritzinsky
    jkoritzinsky committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    e11e1af View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/DllImportGenerator' into incremental-generator

    @jkoritzinsky
    jkoritzinsky committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    b5ebd83 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2021

  1. Merge branch 'incremental-generator' into incremental-generator-tpi

    @jkoritzinsky
    jkoritzinsky committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    e0f5c3b View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. Fix PreserveSig handling.

    @jkoritzinsky
    jkoritzinsky committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    21ba952 View commit details
    Browse the repository at this point in the history

  2. Upgrade tooling to be able to build from the CLI and VS2022 with the … 

    …incremental generator.
    @jkoritzinsky
    jkoritzinsky committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    231e323 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'incremental-generator' into incremental-generator-tpi

    @jkoritzinsky
    jkoritzinsky committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    19f5802 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2021

  1. Reorganize file and remove unneeded record (will always compare as di… 

    …fferent, so no reason to keep around).
    @jkoritzinsky
    jkoritzinsky committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    af42e1b View commit details
    Browse the repository at this point in the history

  2. Make more methods static

    @jkoritzinsky
    jkoritzinsky committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    4931e3a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'incremental-generator' into incremental-generator-tpi

    @jkoritzinsky
    jkoritzinsky committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    d067c78 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/DllImportGenerator' of github.com:dotnet/runtim… 

    …elab into incremental-generator-tpi
    @jkoritzinsky
    jkoritzinsky committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    3d9744b View commit details
    Browse the repository at this point in the history

  5. Make ReturnNativeIdentifier get-only.

    @jkoritzinsky
    jkoritzinsky committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    5e173a0 View commit details
    Browse the repository at this point in the history

  6. Move BoundGenerator to be a nested implementation detail of StubCodeG… 

    …enerator.
    @jkoritzinsky
    jkoritzinsky committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    3d725b9 View commit details
    Browse the repository at this point in the history

  7. Cleanup whitespace.

    @jkoritzinsky
    jkoritzinsky committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    82b02e8 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2021

  1. PR feedback.

    @jkoritzinsky
    jkoritzinsky committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    d8933f2 View commit details
    Browse the repository at this point in the history

  2. Update ref assemblies to match the SDK we're using.

    @jkoritzinsky
    jkoritzinsky committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    a29b161 View commit details
    Browse the repository at this point in the history

  3. Construct GeneratedDllImportData from locals instead of using with … 

    …expressions during initial parsing.
    @jkoritzinsky
    jkoritzinsky committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    2b37003 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2021

  1. Merge branch 'feature/DllImportGenerator' into incremental-generator-tpi

    @jkoritzinsky
    jkoritzinsky authored Aug 6, 2021
    Configuration menu
    Copy the full SHA
    7208fc2 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. Update to released Preview 7 version.

    @jkoritzinsky
    jkoritzinsky committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    3c89ab4 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2021

  1. Use runtime version when appropriate. Update global.json

    @jkoritzinsky
    jkoritzinsky committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    20b9ac7 View commit details
    Browse the repository at this point in the history