Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event for marking the Start/Stop of source generation #258

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT added the area-DllImportGenerator Source Generated stubs for P/Invokes in C# label Oct 22, 2020
Copy link
Member

@elinor-fung elinor-fung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we start a doc for our events?

@AaronRobinsonMSFT
Copy link
Member Author

Should we start a doc for our events?

@elinor-fung I don't think so right now. There isn't a ton of value for anyone to use these given it doesn't tell anyone anything useful right now. I will doc the C# though.

@billwert
Copy link
Member

LGTM!

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 1e3819b into dotnet:DllImportGenerator Oct 23, 2020
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the add_new_eventsource branch October 23, 2020 19:52
jkoritzinsky pushed a commit to jkoritzinsky/runtime that referenced this pull request Sep 20, 2021
…timelab#258)

* Add event for marking the Start/Stop of source generation

Commit migrated from dotnet/runtimelab@1e3819b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-DllImportGenerator Source Generated stubs for P/Invokes in C#
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants