-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle PreserveSig=false #323
Merged
elinor-fung
merged 8 commits into
dotnet:feature/DllImportGenerator
from
elinor-fung:preserveSig
Nov 14, 2020
Merged
Handle PreserveSig=false #323
elinor-fung
merged 8 commits into
dotnet:feature/DllImportGenerator
from
elinor-fung:preserveSig
Nov 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elinor-fung
added
the
area-DllImportGenerator
Source Generated stubs for P/Invokes in C#
label
Nov 9, 2020
Now that we're adding tests that throw exceptions, we should make sure that we don't forget to add the cleanup exception handling to the stubs. |
50 tasks
DllImportGenerator/DllImportGenerator/Marshalling/SafeHandleMarshaller.cs
Outdated
Show resolved
Hide resolved
elinor-fung
force-pushed
the
preserveSig
branch
from
November 13, 2020 06:02
0561588
to
53ee706
Compare
elinor-fung
force-pushed
the
preserveSig
branch
from
November 13, 2020 06:29
53ee706
to
6f1a827
Compare
DllImportGenerator/DllImportGenerator/Marshalling/HResultExceptionMarshaller.cs
Show resolved
Hide resolved
DllImportGenerator/DllImportGenerator/Marshalling/MarshallingGenerator.cs
Outdated
Show resolved
Hide resolved
jkoritzinsky
approved these changes
Nov 14, 2020
DllImportGenerator/DllImportGenerator.UnitTests/CodeSnippets.cs
Outdated
Show resolved
Hide resolved
DllImportGenerator/DllImportGenerator.UnitTests/CodeSnippets.cs
Outdated
Show resolved
Hide resolved
jkoritzinsky
approved these changes
Nov 14, 2020
AaronRobinsonMSFT
approved these changes
Nov 14, 2020
jkoritzinsky
pushed a commit
to jkoritzinsky/runtime
that referenced
this pull request
Sep 20, 2021
* Handle PreserveSig=false * Flag SetLastError=true as unsupported until we add support for it * Add try-finally to generated code * Update doc Commit migrated from dotnet/runtimelab@4562fa7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @AaronRobinsonMSFT @jkoritzinsky
No return value
int as return
UTF-16 string as return
int array as return
SafeHandle as return