Add handling for [In, Out] attributes. #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w usage of [In] or [Out] attributes on by reference parameters or on by value parameters where they have no effect.
…nonblittable by value array testing.
jkoritzinsky
added
the
area-DllImportGenerator
DllImportGenerator/DllImportGenerator/Marshalling/MarshallingGenerator.cs
Show resolved
Hide resolved
DllImportGenerator/DllImportGenerator/Marshalling/MarshallingGenerator.cs
Outdated
Show resolved
Hide resolved
DllImportGenerator/DllImportGenerator/Marshalling/MarshallingGenerator.cs
Outdated
Show resolved
Hide resolved
…elab into out-byval-array
|
This is finally ready for another review pass. |
50 tasks
AaronRobinsonMSFT
approved these changes
Jan 4, 2021
| if (info.IsManagedReturnPosition || (info.IsByRef && info.RefKind != RefKind.In)) | ||
| if (info.IsManagedReturnPosition | ||
| || (info.IsByRef && info.RefKind != RefKind.In) | ||
| || (info.ByValueContentsMarshalKind & ByValueContentsMarshalKind.Out) != 0) |
There was a problem hiding this comment.
Can't we use the HasFlag() function for all of these checks with ByValueContentsMarshalKind?
| @@ -16,6 +16,35 @@ namespace Microsoft.Interop | |||
| CharEncoding CharEncoding | |||
| ); | |||
|
|
|||
| /// <summary> | |||
| /// Describes how to marshal the contents of a value in comparison to the value itself. | |||
| /// Only makes sense for array-like types. For example, an "out" array doesn't change the | |||
There was a problem hiding this comment.
Only makes sense for array-like types.
I'm assuming we have a nice assert or even a Diagnostic warning for the user that one is using In/Out on a type that we think is silly?
There was a problem hiding this comment.
Yes we emit a diagnostic warning or error if someone applies In or Out in a case where the attribute has no effect.
…elab into out-byval-array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement support for [Out] and [In, Out] on by-value arrays. Disallow usage of [In] or [Out] attributes on by reference parameters or on by value parameters where they have no effect.
Integration tests depend on #379