Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont build any packages from libs build in NativeAOT branch #466

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

safern
Copy link
Member

@safern safern commented Dec 15, 2020

Contributes towards: #465

I will port this to dotnet/runtime so that we have that a way to disable it when creating new experiments.

Test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=922198&view=results

cc: @jkotas @MichalStrehovsky

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@safern
Copy link
Member Author

safern commented Dec 15, 2020

I've validated that the test official build is successful and it doesn't produce that package any more. These are the only packages produced from this branch

  Microsoft.DotNet.ILCompiler -> /__w/1/s/artifacts/packages/Release/Shipping/Microsoft.DotNet.ILCompiler.6.0.0-alpha.1.20615.5.nupkg
  Microsoft.DotNet.ILCompiler -> /__w/1/s/artifacts/packages/Release/Shipping/runtime.linux-x64.Microsoft.DotNet.ILCompiler.6.0.0-alpha.1.20615.5.nupkg

@safern safern merged commit 0a84a96 into dotnet:feature/NativeAOT Dec 16, 2020
@safern safern deleted the DontBuildLibPackagesNativeAot branch December 16, 2020 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants