Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning to building static libraries with naot #6651

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

MichalStrehovsky
Copy link
Member

Cc @jkotas @lambdageek

Suggestions for a better wording welcome!

Fixes dotnet/runtime#98356.

@MichalStrehovsky MichalStrehovsky requested a review from a team as a code owner February 13, 2024 20:37
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions to consider.

core/nativeaot/NativeLibrary/README.md Outdated Show resolved Hide resolved
@MichalStrehovsky
Copy link
Member Author

Manually incorporated feedback from both @jkotas and @gewarren since there were conflicting lines.

@MichalStrehovsky MichalStrehovsky merged commit 2890083 into main Feb 14, 2024
5 checks passed
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-1 branch February 14, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NativeAOT: support for building static libraries for Debug CRT on Windows
3 participants