Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments about .NET unload #6939

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Add comments about .NET unload #6939

merged 4 commits into from
Jun 6, 2024

Conversation

agocke
Copy link
Member

@agocke agocke commented Jun 5, 2024

Summary

Note in the .NET hosting docs that the runtime cannot be unloaded.

@agocke agocke marked this pull request as ready for review June 5, 2024 21:14
@agocke agocke requested a review from a team as a code owner June 5, 2024 21:14
@agocke
Copy link
Member Author

agocke commented Jun 5, 2024

@dotnet/appmodel for review

core/hosting/src/NativeHost/nativehost.cpp Outdated Show resolved Hide resolved
@@ -68,8 +68,7 @@ int callSumFunc(char *path, char *funcName, int firstInt, int secondInt)

int result = MyImport(firstInt, secondInt);

// CoreRT libraries do not support unloading
// See https://github.com/dotnet/corert/issues/7887
// NOTE: Native AOT libraries do not support unloading
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add a sentence at the end of this section in the README too? https://github.com/dotnet/samples/tree/main/core/nativeaot/NativeLibrary#loading-shared-libraries-from-c-and-importing-methods?

@agocke agocke merged commit d2053c0 into dotnet:main Jun 6, 2024
4 checks passed
@agocke agocke deleted the no-unloading branch June 6, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants