Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report error in CreateNewImage when no tags are passed in #240

Closed
rainersigwald opened this issue Nov 8, 2022 · 0 comments · Fixed by #241
Closed

Report error in CreateNewImage when no tags are passed in #240

rainersigwald opened this issue Nov 8, 2022 · 0 comments · Fixed by #241

Comments

@rainersigwald
Copy link
Member

rainersigwald commented Nov 8, 2022 •
edited
Loading

The silent failure is because there is nothing in this foreach:

sdk-container-builds/Microsoft.NET.Build.Containers/CreateNewImage.cs

Line 237 in 3e0470b

foreach (var tag in ImageTags)

So we just don't attempt any push. We should probably error if ImageTags is empty.

Originally posted by @rainersigwald in #236 (comment)
rainersigwald added a commit to rainersigwald/sdk-container-builds that referenced this issue Nov 8, 2022
@rainersigwald
Error when no tags are given to CreateNewImage
38c2d9e 
If something caused ImageTags to be empty, the foreach-tag-push loop
would silently do nothing, which is a confusing user experience.

Instead, emit an error and fail. Fixes dotnet#240.
@rainersigwald rainersigwald mentioned this issue Nov 8, 2022
Merged
rainersigwald added a commit to rainersigwald/sdk-container-builds that referenced this issue Nov 11, 2022
@rainersigwald
Error when no tags are given to CreateNewImage
36e9d4c 
If something caused ImageTags to be empty, the foreach-tag-push loop
would silently do nothing, which is a confusing user experience.

Instead, let MSBuild emit an error and fail. Fixes dotnet#240.
rainersigwald added a commit to rainersigwald/sdk-container-builds that referenced this issue Nov 11, 2022
@rainersigwald
Error when no tags are given to CreateNewImage
25751f5 
If something caused ImageTags to be empty, the foreach-tag-push loop
would silently do nothing, which is a confusing user experience.

Instead, let MSBuild emit an error and fail. Fixes dotnet#240.
baronfel pushed a commit that referenced this issue Nov 15, 2022
@rainersigwald
Error when no tags are given to CreateNewImage (#241)
dcb2c73 
Fixes #240
GangWang01 pushed a commit to GangWang01/sdk that referenced this issue Mar 20, 2023
@rainersigwald
Error when no tags are given to CreateNewImage (dotnet#241)
ee5cbbf 
Fixes dotnet/sdk-container-builds#240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Error when no tags are given to CreateNewImage rainersigwald/sdk-container-builds
1 participant
@rainersigwald