Refactor tests & disable the test for the config binding generator

dotnet · Apr 9, 2023 · 2391c08 · 2391c08
1 parent 14dc074
commit 2391c08
Showing 1 changed file with 2 additions and 13 deletions.
diff --git a/src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToUseAnalyzers.cs b/src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToUseAnalyzers.cs
@@ -12,7 +12,6 @@
 using System.Collections.Generic;
 using System;
 using Xunit.Abstractions;
-using System.Runtime.InteropServices;
 using Microsoft.NET.TestFramework.ProjectConstruction;
 
 namespace Microsoft.NET.Build.Tests
@@ -32,14 +31,9 @@ public void It_resolves_offbydefaultgenerator_correctly(GeneratorSpec generator,
                 .WithSource()
                 .WithProjectChanges(project =>
                 {
+                    var ns = project.Root.Name.Namespace;
                     if (isEnabled != null)
                     {
-                        var ns = project.Root.Name.Namespace;
-                        // Delete when we have a new targeting pack that contains Microsoft.Extensions.Configuration.Binder.SourceGeneration.
-                        if (generator == GeneratorSpec.ConfigurationBinding)
-                        {
-                            project.Root.Add(new XElement(ns + "ItemGroup", new XElement("Analyzer", new XAttribute("Include", "does_not_yet_exist\\Microsoft.Extensions.Configuration.Binder.SourceGeneration.dll"))));
-                        }
                         project.Root.Add(new XElement(ns + "PropertyGroup", new XElement(generator.EnablingPropertyName, isEnabled)));
                     }
                 });
@@ -57,11 +51,6 @@ public void It_enables_offbydefaultgenerator_for_PublishAot(GeneratorSpec genera
                 .WithProjectChanges(project =>
                 {
                     var ns = project.Root.Name.Namespace;
-                    // Delete when we have a new targeting pack that contains Microsoft.Extensions.Configuration.Binder.SourceGeneration.
-                    if (generator == GeneratorSpec.ConfigurationBinding)
-                    {
-                        project.Root.Add(new XElement(ns + "ItemGroup", new XElement("Analyzer", new XAttribute("Include", "does_not_yet_exist\\Microsoft.Extensions.Configuration.Binder.SourceGeneration.dll"))));
-                    }
                     project.Root.Add(new XElement(ns + "PropertyGroup", new XElement("PublishAot", "true")));
                 });
 
@@ -96,7 +85,7 @@ public record GeneratorSpec(string EnablingPropertyName, string DllFileName)
         public static IEnumerable<object[]> OffByDefaultGenerators()
         {
             yield return new object[] { GeneratorSpec.RequestDelegate };
-            yield return new object[] { GeneratorSpec.ConfigurationBinding };
+            // yield return new object[] { GeneratorSpec.ConfigurationBinding };
         }
 
         public static IEnumerable<object[]> OffByDefaultGeneratorTestData()