Skip to content

Commit

Permalink
Fix version mismatches
Browse files Browse the repository at this point in the history
  • Loading branch information
JanKrivanek committed Oct 21, 2022
1 parent 939ee0a commit d360677
Show file tree
Hide file tree
Showing 12 changed files with 16 additions and 98 deletions.
2 changes: 1 addition & 1 deletion eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
<!-- test dependencies -->
<MicrosoftTemplateEngineMocksPackageVersion>$(MicrosoftTemplateEngineAbstractionsPackageVersion)</MicrosoftTemplateEngineMocksPackageVersion>
<MicrosoftTemplateEngineTestHelperPackageVersion>$(MicrosoftTemplateEngineAbstractionsPackageVersion)</MicrosoftTemplateEngineTestHelperPackageVersion>
<MicrosoftTemplateEngineAuthoringTemplateVerifierVersion>$(MicrosoftTemplateEngineAbstractionsPackageVersion)</MicrosoftTemplateEngineAuthoringTemplateVerifierVersion>
<MicrosoftTemplateEngineAuthoringTemplateVerifierVersion>$(MicrosoftTemplateEngineAbstractionsPackageVersion)</MicrosoftTemplateEngineAuthoringTemplateVerifierVersion>
</PropertyGroup>
<PropertyGroup>
<!-- Dependencies from https://github.com/Microsoft/visualfsharp -->
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

30 changes: 15 additions & 15 deletions src/Tests/dotnet-new.Tests/CommonTemplatesTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ public async void AllCommonProjectsCreateRestoreAndBuild(string expectedTemplate
VerifyCommandOutput = true,
VerificationExcludePatterns = new[] { "*.cs", "*.fs", "*.vb", "*.*proj" },
DoNotPrependCallerMethodNameToScenarioName = false,
DoNotAppendParamsToScenarioName = true,
DoNotPrependTemplateToScenarioName = true,
DoNotAppendTemplateArgsToScenarioName = true,
DoNotPrependTemplateNameToScenarioName = true,
}
.WithCustomScrubbers(
ScrubbersDefinition.Empty
Expand Down Expand Up @@ -184,9 +184,9 @@ public async void AllCommonProjectsCreate_NoRestore(string expectedTemplateName,
ExpectationsDirectory = "Approvals",
VerifyCommandOutput = true,
VerificationIncludePatterns = new[] { "*.txt" },
DoNotAppendParamsToScenarioName = true,
DoNotAppendTemplateArgsToScenarioName = true,
SettingsDirectory = _fixture.HomeDirectory,
DoNotPrependTemplateToScenarioName = true,
DoNotPrependTemplateNameToScenarioName = true,
}
.WithCustomScrubbers(
ScrubbersDefinition.Empty
Expand All @@ -212,9 +212,9 @@ public async void AllCommonItemsCreate(string expectedTemplateName, string templ
ExpectationsDirectory = "Approvals",
VerifyCommandOutput = true,
VerificationIncludePatterns = new[] { "*.txt" },
DoNotAppendParamsToScenarioName = true,
DoNotAppendTemplateArgsToScenarioName = true,
SettingsDirectory = _fixture.HomeDirectory,
DoNotPrependTemplateToScenarioName = true,
DoNotPrependTemplateNameToScenarioName = true,
}
.WithCustomScrubbers(
ScrubbersDefinition.Empty
Expand Down Expand Up @@ -364,9 +364,9 @@ public async void TopLevelProgramSupport_WhenFlagIsEnabled(string? langVersion)
ExpectationsDirectory = "Approvals",
OutputDirectory = workingDir,
SettingsDirectory = _fixture.HomeDirectory,
// DoNotPrependTemplateToScenarioName = true,
DoNotAppendParamsToScenarioName = true,
ScenarioDistinguisher = langVersion == null ? "#NoLang" : null,
// DoNotPrependTemplateNameToScenarioName = true,
DoNotAppendTemplateArgsToScenarioName = true,
ScenarioName = langVersion == null ? "#NoLang" : null,
}
.WithCustomScrubbers(
ScrubbersDefinition.Empty
Expand Down Expand Up @@ -400,9 +400,9 @@ public async void TopLevelProgramSupport_WhenFlagIsEnabled_NoFileScopedNamespace
TemplateSpecificArgs = args,
ExpectationsDirectory = "Approvals",
SettingsDirectory = _fixture.HomeDirectory,
// DoNotPrependTemplateToScenarioName = true,
DoNotAppendParamsToScenarioName = true,
DoNotPrependTemplateToScenarioName = true,
// DoNotPrependTemplateNameToScenarioName = true,
DoNotAppendTemplateArgsToScenarioName = true,
DoNotPrependTemplateNameToScenarioName = true,
}
.WithCustomScrubbers(
ScrubbersDefinition.Empty
Expand Down Expand Up @@ -519,9 +519,9 @@ public async void FeaturesSupport(
ExpectationsDirectory = "Approvals",
OutputDirectory = workingDir,
SettingsDirectory = _fixture.HomeDirectory,
DoNotPrependTemplateToScenarioName = false,
DoNotAppendParamsToScenarioName = true,
ScenarioDistinguisher = !buildPass ?
DoNotPrependTemplateNameToScenarioName = false,
DoNotAppendTemplateArgsToScenarioName = true,
ScenarioName = !buildPass ?
"OutOfSupport" :
$"Nullable-{supportsNullable}#TopLevel-{supportsTopLevel}#ImplicitUsings-{supportsImplicitUsings}#FileScopedNs-{supportsFileScopedNs}" + (langVersion == null ? "#NoLang" : null),
VerificationExcludePatterns = buildPass ? null : new[] { "*" },
Expand Down

0 comments on commit d360677

Please sign in to comment.