Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet-publish: Is there a limitation on what projects are publishable? #4685

Closed
borgdylan opened this issue Dec 22, 2015 · 5 comments
Closed
Labels
Milestone

Comments

@borgdylan
Copy link

I have managed to run dotnet-publish on the cli projects but not on a simple command line app that runs fine using dotnet-run.

@krwq
Copy link
Member

krwq commented Dec 23, 2015

Thanks for finding this 😃 I think that's a bug on our side. cc: @piotrpMSFT @blackdwarf @davidfowl

@blackdwarf
Copy link

@borgdylan can you give us more info? What does your project.json look like? What is the OS and what is the version of the CLI you are using?

@borgdylan
Copy link
Author

I have meaning to close this since yesterday. This occurs only if the project is in a subdirectory of where the CLI is installed. If the project is moved out, publishing carries on normally.

I am using a custom build that targets mono rather than CoreCLR. I will be making all my changes public on github as soon as I get a proper build script fleshed out.

@borgdylan borgdylan reopened this Dec 24, 2015
@borgdylan
Copy link
Author

After updating the code, I can't seem to publish anything but the actual CLI bits. I conducted all tests with my CLI fork that targets mono that I installed using the debian package that the build script made for me.

@borgdylan
Copy link
Author

The bug was caused due to a context RID not matching the actual RID. The context RID made was ubuntu.15.10-x86 yet the RID made was ubuntu.14.04-x64. The dotnet-publish command was considering both ubuntu.15.10-x86 and ubuntu.15.10-x64 so I modified the code to ignore the Ubuntu version. That fixes the bug for me.

https://github.com/borgdylan/dotnet-cli/blob/master/src/Microsoft.DotNet.Tools.Publish/PublishCommand.cs#L70

wli3 referenced this issue in wli3/cli Jul 14, 2017
@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the Backlog milestone Jan 31, 2020
rainersigwald pushed a commit to rainersigwald/sdk that referenced this issue Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants