-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building the CLI gives a out of memory exception #4693
Comments
I'm seeing the same. This only started yesterday and only repros on el cap. Exception is getting swallowed so no idea where this is coming from... |
So 2 things:
|
CI is not on El Cap yet. Have you identified the offending PR? |
F# support PR is what makes it fail |
I have not added an E2E test for fsharp. I cannot repro. No El cap locally in OS X |
We are seeing this our VSO builds for OS X. Relevant Error:
This seems to have appeared with the Server GC change to CoreHost. |
Taking a look |
The PR dotnet/cli#658 undoes SERVER_GC change for CLI which causes this problem. We need to resolve #4567 to enable SERVER_GC by default [OR] at least we should have a temporary solution of disabling SERVER_GC using an environment flag, so VSO can set this variable to switch off. Otherwise it is enabled. How does that sound? |
@davidfowl, to unblock just flip the bit. Set to "0" |
@janvorli Can you please take a look to understand why enabling Server GC would trigger OOM on OSX Elcapitan? |
I'll take a look at this |
Reopening... @piotrpMSFT @sergiy-k |
Finally! |
Noticed there is no milestone... Also just hit this, would love to compile a project on El Capitan ⛵ |
This is affecting vso osxbuild |
Clicked the wrong button on phone :( |
Just to make it obvious (since I pieced it together from a couple linked threads): export COREHOST_SERVER_GC=0 And then build happily :) (With |
@janvorli ptal |
FYI I turned it off by default for now |
@davidfowl Which PR? |
@davidfowl please @ mention on the PR or commit message for the host, #WorldMovedUnderFeet |
…rve VA This change modifies the MAPMapPEFile in PAL to use ExecutableAllcator instead of mmap in order to reserve VA for managed executable images. This allows all NI images to be located near each other and close to the coreclr library, which also allows the runtime to generate code that is more efficient (by avoiding usage of jump stubs). It also fixes an issue (https://github.com/dotnet/cli/issues/652) where CLI fails with OutOfMemoryException which turned out to be related to loading NI files. Due to a certain allocation pattern, mmap can place an NI file at a region of virtual address space that does not have any free memory around the NI images. As a result, when the runtime needs to allocate memory for jump stubs for the image it cannot find any available memory near the image and fails with OutOfMemoryException.
…rve VA This change modifies the MAPMapPEFile in PAL to use ExecutableAllcator instead of mmap in order to reserve VA for managed executable images. This allows all NI images to be located near each other and close to the coreclr library, which also allows the runtime to generate code that is more efficient (by avoiding usage of jump stubs). It also fixes an issue (https://github.com/dotnet/cli/issues/652) where CLI fails with OutOfMemoryException which turned out to be related to loading NI files. Due to a certain allocation pattern, mmap can place an NI file at a region of virtual address space that does not have any free memory around the NI images. As a result, when the runtime needs to allocate memory for jump stubs for the image it cannot find any available memory near the image and fails with OutOfMemoryException.
This is fixed. |
Pass the correct delimiter for DefineConstants for C# and VB
* Update dependencies from https://github.com/dotnet/cli build 20200717.1 Microsoft.DotNet.Cli.Runtime From Version 3.1.400-preview.20365.4 -> To Version 3.1.400-preview.20367.1 * Update dependencies from https://github.com/dotnet/cli build 20200717.2 Microsoft.DotNet.Cli.Runtime From Version 3.1.400-preview.20365.4 -> To Version 3.1.400-preview.20367.2 * Remove darc int feeds Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Jason Zhai <AzureTest@vwuzhai002.redmond.corp.microsoft.com>
[main] Update dependencies from dotnet/command-line-api - fix build after contract change
[main] Update dependencies from dotnet/command-line-api - fix build after contract change
[main] Update dependencies from dotnet/command-line-api - fix build after contract change
On OSX El Capitan.
The text was updated successfully, but these errors were encountered: