[release/3.1.3xx] Pin HostModel #11187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pin the host model at 3.1.2. It is not required that we update HostModel except to test a new runtime in the SDK, or if breaking changes were made. When this host model does change. it requires that we pull a new stage0 SDK from dotnet/installer, which is a significant cost.
wtgodbe
approved these changes
Apr 7, 2020
|
the dotnet-install TLS failure is hitting us here |
|
@wli3 is there a PR in this repo already to work around the TLS issue? |
|
@wtgodbe The dotnet-install changes just got rolled out so a retry should be sufficient. |
|
@mmitche does this pinning affect dotnet/core-setup#9012 changes ( dotnet/core-setup#11244)? FYI @swaroop-sridhar ... I'm afraid I'm not familiar enough with these release candidate workflows to determine whether the release\3.1 has actually gone out either way... |
|
It should not. The host model here is just used for testing purposes. Newest host models are still distributed with the runtime or Core Sdk. |
wli3
pushed a commit
to wli3/sdk
that referenced
this pull request
Jul 21, 2020
This reverts commit 1d88a76.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin the host model at 3.1.2. It is not required that we update HostModel except to test a new runtime in the SDK, or if breaking changes were made. When this host model does change. it requires that we pull a new stage0 SDK from dotnet/installer, which is a significant cost.