Allow workloads to override property defaults #14393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsplaisted
force-pushed
the
workload-updates
branch
2 times, most recently
from
6bf1cba
to
d155e5e
Compare
Workload targets imports now go soon after target framework inference, allowing them to override property defaults from the .NET SDK
dsplaisted
force-pushed
the
workload-updates
branch
from
d155e5e
to
cb3f97c
Compare
wli3
reviewed
Nov 2, 2020
wli3
approved these changes
Nov 3, 2020
wli3
reviewed
Nov 3, 2020
| <PropertyGroup Condition="'$(SupportedOSPlatformVersion)' == ''"> | ||
| <SupportedOSPlatformVersion>$(TargetPlatformVersion)</SupportedOSPlatformVersion> | ||
| </PropertyGroup> | ||
| <Import Project="$(AfterMicrosoftNETSdkTargets)" Condition="'$(AfterMicrosoftNETSdkTargets)' != ''"/> |
sfoslund
approved these changes
Nov 3, 2020
pjcollins
added a commit
to dotnet/android
that referenced
this pull request
Nov 5, 2020
The `Microsoft.Android.Sdk` pack has been broken up into three Host OS packs. Depending on the operating system used during the build, one or more of the following packs will now be created: * `Microsoft.Android.Sdk.linux-x64` * `Microsoft.Android.Sdk.osx-x64` * `Microsoft.Android.Sdk.windows-x64` This is still mostly missing Linux support, which can be addressed in a future PR that adds a linux build step to our commercial pipeline. TODO: Once we bump to a `dotnet` install which contains [dotnet/sdk#14393][0], we'll need to replace mentions of `windows-x64` with `win-x64`. [0]: dotnet/sdk#14393
|
This is a significant breaking change because now they're before |
This was referenced Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workload targets imports now go soon after target framework inference, allowing them to override property defaults from the .NET SDK