Add support for Pgo Mibc files to be used by the SDK #17769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidwrighton
commented
May 21, 2021
davidwrighton
commented
- A new ItemList (PublishReadyToRunPgoFiles) can be used to specify a custom list of Mibc files
- Any Mibc files defined in associated RuntimePacks via a RuntimeAsset with AssetType PgoData will also be included
- This behavior can be disabled by setting PublishReadyToRunUseRuntimePackOptimizationData to false
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
See related PR dotnet/arcade#7425 for logic around RuntimeList.xml generation |
davidwrighton
requested review from
dsplaisted,
trylek and
AntonLapounov
and removed request for
trylek
AntonLapounov
approved these changes
May 21, 2021
| <ItemGroup> | ||
| <_ReadyToRunPgoFiles Include="@(PublishReadyToRunPgoFiles)" /> | ||
| <_ReadyToRunPgoFiles Include="@(RuntimePackAsset)" | ||
| Condition="'%(RuntimePackAsset.AssetType)' == 'pgodata' and '%(RuntimePackAsset.Extension)' == '.mibc' and ('$(PublishReadyToRunUseRuntimePackOptimizationData)' == 'true' or '$(PublishReadyToRunUseRuntimePackOptimizationData)' == '')" /> |
There was a problem hiding this comment.
Nit: Condition is not aligned with Include. I would either use '$(PublishReadyToRunUseRuntimePackOptimizationData)' != 'false' or default that property to true if not set.
…uilds and pull optimization data details from RuntimeList.xml if present
davidwrighton
force-pushed
the
add_mibc_to_sdk
branch
from
3c2f478 to
0d5f55b
Compare
davidwrighton
added a commit
to davidwrighton/sdk
that referenced
this pull request
May 27, 2021
- A new ItemList (PublishReadyToRunPgoFiles) can be used to specify a custom list of Mibc files - Any Mibc files defined in associated RuntimePacks via a RuntimeAsset with AssetType PgoData will also be included This behavior can be disabled by setting PublishReadyToRunUseRuntimePackOptimizationData to false
davidwrighton
added a commit
that referenced
this pull request
May 27, 2021
…he SDK (#17930) Port #17769 to preview 5. - A new ItemList (PublishReadyToRunPgoFiles) can be used to specify a custom list of Mibc files - Any Mibc files defined in associated RuntimePacks via a RuntimeAsset with AssetType PgoData will also be included This behavior can be disabled by setting PublishReadyToRunUseRuntimePackOptimizationData to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.