-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A simple composite R2R test for singlefile apps #18366
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
publishCommand | ||
.Execute(PublishSingleFile, ReadyToRun, ReadyToRunComposite, RuntimeIdentifier, extractAll ? IncludeAllContent: "") | ||
.Should() | ||
.Pass(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we run the resulting binary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. Running the binary would be nice :-)
CC: @mangod9 @AntonLapounov - sunglefile composite r2r is now functional in SDK main. |
This is great. Thanks @VSadov for enabling this. We should discuss whether it should be the default |
NOTE: The test is expected to fail until dotnet/runtime#53739 is merged and propagated to SDK.