-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Support for PredefinedCultureOnly property #18672
Initial Support for PredefinedCultureOnly property #18672
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
aa93e39
to
4a14f98
Compare
75b2eba
to
b5c39d3
Compare
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAProjectWithAllFeatures.cs
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibrary.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibrary.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibrary.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibrary.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibrary.cs
Outdated
Show resolved
Hide resolved
@@ -59,7 +59,7 @@ | |||
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | |||
<CopyToPublishDirectory>Never</CopyToPublishDirectory> | |||
</Content> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be setting the <PredefinedCulturesOnly>
property in the top PropertyGroup of this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dsplaisted I have returned back the changes in GivenThatWeWantToPublishAProjectWithAllFeatures.cs and TestApp as @eerhardt suggested to keep it to test the behavior when enabling the property in down-level version even if it will not have any runtime effect.
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets
Outdated
Show resolved
Hide resolved
…rary.cs Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
…rary.cs Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dsplaisted are we good to merge? or you have more comments? |
@tarekgh I've merged it |
Co-authored-by: Matt Mitchell <mmitche@microsoft.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Matt Mitchell <mmitche@microsoft.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
We are changing the Invariant Globalization mode behavior in .NET 6.0 to force it to throw exception by default when creating non-Invariant cultures dotnet/runtime#54247. The behavior can be controlled by a config switch
System.Globalization.PredefinedCulturesOnly
that we need to support it through the SDK to have msbuild property.