-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from dotnet/runtime #20859
[main] Update dependencies from dotnet/runtime #20859
Conversation
…0909.5 Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.App.Runtime.win-x64 , System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Host.win-x64 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , System.Text.Encoding.CodePages , System.Security.Cryptography.ProtectedData , System.Resources.Extensions , System.Reflection.MetadataLoadContext From Version 7.0.0-alpha.1.21425.4 -> To Version 7.0.0-alpha.1.21459.5
@ViktorHofer can you take a look at the build error? Is this expected?
|
cc @maryamariyan @michaelgsharp @safern @tarekgh who are the owners of Microsoft.Extensions.DependencyModel (ICompilationAssemblyResolver) |
…0910.1 Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.App.Runtime.win-x64 , System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Host.win-x64 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , System.Resources.Extensions , System.Reflection.MetadataLoadContext , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages From Version 7.0.0-alpha.1.21425.4 -> To Version 7.0.0-alpha.1.21460.1
looking |
…0910.17 Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.App.Runtime.win-x64 , System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Host.win-x64 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , System.Resources.Extensions , System.Reflection.MetadataLoadContext , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages From Version 7.0.0-alpha.1.21425.4 -> To Version 7.0.0-alpha.1.21460.17
…0911.7 Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.App.Runtime.win-x64 , System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Host.win-x64 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , System.Resources.Extensions , System.Reflection.MetadataLoadContext , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages From Version 7.0.0-alpha.1.21425.4 -> To Version 7.0.0-alpha.1.21461.7
…0913.1 Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.App.Runtime.win-x64 , System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Host.win-x64 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , System.Resources.Extensions , System.Reflection.MetadataLoadContext , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages From Version 7.0.0-alpha.1.21425.4 -> To Version 7.0.0-alpha.1.21463.1
@maryamariyan I know your xunit issue is first priority, do you prefer one of the other folks above take a look at this one? We are a bit stale in our main flow. |
This was caused by nullable annotations being added to Microsoft.Extensions here: dotnet/runtime#57445 I believe we can simply just update the tests here to match the nullable annotations which were added. This type of break is expected when new assemblies add nullable annotations and there are already upstack assemblies with nullable enabled. |
This should fix it, I just added some null-forgiving operators, since this is test code and it'd be OK if it throws NRE (test failure). |
Thanks, I was about to push the same change.. |
Bunch of WASM tests have net6.0 hard coded in them. I guess I'll let all tests finish before we fix those.
|
thanks @ericstj for unblocking this. |
cc @javiercn @pranavkm @captainsafia for the blazor test failures. Looks like a lot of them. It wasn't clear what to update. I see host tests failing because the HostModel assembly is still referencing 6.0.0 dependencies, yet SDK is deploying 7.0 (and doesn't implement redirection on .NETFramework):
@agocke / @eerhardt looks like this needs an update (and ideally should build against live bits) |
According to dotnet/runtime#1823 (comment), we should have a subscription set up that updates those dependencies. |
I'm looking into it. It looks like the NuGet package version is |
@javiercn could you update the Blazor SDK tests.? |
@pranavkm I updated the Razor/Blazor baselines, the only two tests failing after I believe have unrelated failures. What I'm seeing is that they fail during CreateAppHost. Here is one sample exception
|
@javiercn - the |
…0913.20 Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.App.Runtime.win-x64 , System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Host.win-x64 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , System.Resources.Extensions , System.Reflection.MetadataLoadContext , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages From Version 7.0.0-alpha.1.21425.4 -> To Version 7.0.0-alpha.1.21463.20
…0914.4 Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.App.Runtime.win-x64 , System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Host.win-x64 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , System.Resources.Extensions , System.Reflection.MetadataLoadContext , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages From Version 7.0.0-alpha.1.21425.4 -> To Version 7.0.0-alpha.1.21464.4
{ | ||
foreach (var assembly in library.Assemblies) | ||
{ | ||
var dll = Path.Combine(Directory.GetCurrentDirectory(), "refs", Path.GetFileName(assembly)); | ||
if (File.Exists(dll)) | ||
{ | ||
assemblies.Add(dll); | ||
assemblies!.Add(dll); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead add a check before the loop?
if (assemblies == null) return false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on second thought if someone does pass null here it will blow up with NRE as before. disregard.
This pull request updates the following dependencies
From https://github.com/dotnet/runtime