Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OS and Process Architecture #21517

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Conversation

marcpopMSFT
Copy link
Member

@marcpopMSFT marcpopMSFT commented Sep 28, 2021

Description

During our discussions around arm64 it became clear that we weren't sure how often customers use an SDK that doesn't match their current OS. Adding this will help us answer that question so we know whether to prioritize this or not.

Regression?

No

Risk

Low, no functional change.

For performance measurements, I ran dotnet build --help 100 times in a row with and without the change which triggers on telemetry call. I found it 109 seconds with the change and 108 seconds without for a slowdown of ~10ms potentially.

Verification

[X] Manual (required)
[x] Automated

@marcpopMSFT marcpopMSFT merged commit bdd7a1e into release/6.0.1xx Oct 13, 2021
@marcpopMSFT marcpopMSFT deleted the marcpopMSFT-Architecture branch October 18, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants