Add artifacts post processing #24012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
reviewed
Feb 18, 2022
src/Assets/TestProjects/VSTestDataCollectorSample/AttachmentProcessorDataCollector.csproj
Outdated
Show resolved
Hide resolved
src/Assets/TestProjects/VSTestDataCollectorSample/AttachmentProcessorDataCollector.csproj
Outdated
Show resolved
Hide resolved
...Assets/TestProjects/VSTestDataCollectorSampleNoMerge/AttachmentProcessorDataCollector.csproj
Outdated
Show resolved
Hide resolved
src/Assets/TestProjects/VSTestMultiProjectSolution/test1/test1.csproj
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Feb 18, 2022
Evangelink
reviewed
Feb 18, 2022
src/Tests/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsArtifactPostProcessing.cs
Outdated
Show resolved
Hide resolved
src/Tests/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsArtifactPostProcessing.cs
Outdated
Show resolved
Hide resolved
Comment on lines
+39
to
+42
| TestAsset testInstance = _testAssetsManager.CopyTestAsset("VSTestMultiProjectSolution", Guid.NewGuid().ToString()) | ||
| .WithSource(); | ||
|
|
||
| string runsettings = GetRunsetting(testInstance.Path); |
There was a problem hiding this comment.
THis is similar in all your tests, might be worth having a method for it? Maybe only the TestAsset creation.
There was a problem hiding this comment.
mmm what you mean?I need two item here testinstance and the runsettings file path for the command line, how would you organize?
src/Tests/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsArtifactPostProcessing.cs
Outdated
Show resolved
Hide resolved
src/Tests/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsArtifactPostProcessing.cs
Show resolved
Hide resolved
src/Tests/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsArtifactPostProcessing.cs
Outdated
Show resolved
Hide resolved
src/Tests/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsArtifactPostProcessing.cs
Outdated
Show resolved
Hide resolved
src/Tests/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsArtifactPostProcessing.cs
Outdated
Show resolved
Hide resolved
src/Tests/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsArtifactPostProcessing.cs
Outdated
Show resolved
Hide resolved
Comment on lines
+169
to
+197
| private void BuildDataCollector() | ||
| => LazyInitializer.EnsureInitialized(ref s_dataCollectorDll, ref s_dataCollectorInitLock, () => | ||
| { | ||
| TestAsset testInstance = _testAssetsManager.CopyTestAsset("VSTestDataCollectorSample").WithSource(); | ||
|
|
||
| string testProjectDirectory = testInstance.Path; | ||
|
|
||
| new BuildCommand(testInstance) | ||
| .Execute("/p:Configuration=Release") | ||
| .Should() | ||
| .Pass(); | ||
|
|
||
| return Directory.GetFiles(testProjectDirectory, "AttachmentProcessorDataCollector.dll", SearchOption.AllDirectories).Single(x => x.Contains("bin")); | ||
| }); | ||
|
|
||
| private void BuildDataCollectorNoMerge() | ||
| => LazyInitializer.EnsureInitialized(ref s_dataCollectorNoMergeDll, ref s_dataCollectorInitLock, () => | ||
| { | ||
| TestAsset testInstance = _testAssetsManager.CopyTestAsset("VSTestDataCollectorSampleNoMerge").WithSource(); | ||
|
|
||
| string testProjectDirectory = testInstance.Path; | ||
|
|
||
| new BuildCommand(testInstance) | ||
| .Execute("/p:Configuration=Release") | ||
| .Should() | ||
| .Pass(); | ||
|
|
||
| return Directory.GetFiles(testProjectDirectory, "AttachmentProcessorDataCollector.dll", SearchOption.AllDirectories).Single(x => x.Contains("bin")); | ||
| }); |
There was a problem hiding this comment.
This looks so weird. Why do we need static members that holds something that is changed for each test?
There was a problem hiding this comment.
datacollectors are not changed for every tests, we reuse the same compilation for every tests(build on ctor). I prefer this instead of fixture to avoid the creation of class/apply interface etc...looks simpler to me.
…ocessorDataCollector.csproj Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
…hmentProcessorDataCollector.csproj Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
…ctPostProcessing.cs Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
…ctPostProcessing.cs Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
|
@Evangelink refactored a bit the main Run() splitting between run for test containers and run with MSBuild, removed non safe write trace(I do the check inside there, we'll have more closure but it's ok). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to microsoft/vstest#1811