-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from dotnet/runtime #27149
[main] Update dependencies from dotnet/runtime #27149
Conversation
…0813.1 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-rc.1.22411.12 -> To Version 7.0.0-rc.1.22413.1
Notification for subscribed users from https://github.com/dotnet/runtime:@dnr-codeflow Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.
|
1 similar comment
Notification for subscribed users from https://github.com/dotnet/runtime:@dnr-codeflow Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.
|
…0813.9 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-rc.1.22411.12 -> To Version 7.0.0-rc.1.22413.9
@pavelsavara this looks familiar:
|
…0814.6 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-rc.1.22411.12 -> To Version 7.0.0-rc.1.22414.6
@lewing / @steveisok / @SamMonoRT the wasm tests are hitting a baseline failure. Can you take a look? https://github.com/dotnet/sdk/blob/main/src/Tests/Microsoft.NET.Sdk.Razor.Tests/AspNetSdkBaselineTest.cs#L359 |
@javiercn can you have a look at the static web assets tests @jeffschwMSFT there are several Microsoft.NET.Build.Tests failures that are not wasm related. |
@lewing thanks. They look like restore 429's and will need a rerun once we have the fix for the wasm. |
@javiercn @TanayParikh do you use some tool to generate the baselines for the blazor tests? |
Yes. I believe it's just a matter of updating: sdk/src/Tests/Microsoft.NET.Sdk.Razor.Tests/AspNetSdkBaselineTest.cs Lines 29 to 33 in dc4f499
However, is this change expected? |
Could you do that, please?
I wouldn't know. |
I can definitely do it, but just want to confirm if this is an expected change. I believe @pavelsavara has been making some changes in this area so he may have additional context? |
What change are you talking about btw? You linked to: #if GENERATE_SWA_BASELINES
public static bool GenerateBaselines = true;
#else
public static bool GenerateBaselines = false;
#endif This hasn't changed in the last year. |
Essentially just need to add a |
If you share the changes, then I could try to validate them. |
what is the potential value of test deleting overeager and useless tests should be under consideration. |
Yes, we have added some source .ts and .js files from which the dotnet.js is composed. I'm not sure how exactly it impacts this test.
I should be able to validate them too. |
…0815.13 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-rc.1.22411.12 -> To Version 7.0.0-rc.1.22415.13
Thanks for taking a look, who has the next action on this investigation? We are about to snap for RC1 and this will soon become blocking. Thanks |
Looks like we're seeing a new error now: Microsoft.DotNet.Watcher.Tools.GlobbingAppTests.DeleteSourceFolder (and other tests)
Does anyone have context on this error? Previously:
Which isn't showing in the CI any longer. |
adding @dotnet/domestic-cat, @LakshanF, and @MichalStrehovsky to see if they have insight into this new error.
|
Likely a test issue? Not sure where the test is though to check. Both the errors, NETSDK1083 and NETSDK1183 seem valid when rid is "invalid-rid" |
An example is the following: No rid seems to be passed. Was there a recent change in the SDK that requires that (eg. no implicit rid any longer)? |
Lakshan and I took a deeper look. It seems that one of the errors is a red herring (as the test is expecting that), the other implies a restore failure - so rerunning. |
This failure is durable:
Given this Wasm, I am not sure why this error is firing. @lewing? |
Does this generate bin logs, and can I access those? |
Seems reasonable, creating an issue to track this. Edit: dotnet/aspnetcore#43834
It's not an issue with a single test. It's a collection of baselines. That may just be the first in sorted order. |
Can you give some more context? What is due to it? |
are being added to the baselines when I regenerate them. I can put up a PR with these updated baselines, but wasn't sure if #27303 would mean these files would subsequently be no longer expected (thereby failing the baselines, and requiring a revert). |
This is |
I may've been using an older SDK build to generate those. Regardless, the specific version isn't necessarily of concern here given it'll get swapped out for the When I true to build the sdk from |
It IS a concern because if you are using the older runtime version, it will have the dotnet-crypto-worker.js file. And if you are using the newer runtime version, it won't. |
Ah okay, thanks for the clarification! Will take another look tomorrow. In that case, given the CI is failing, that seems to indicate that some other file is being added (I saw the Edit; if anyone can advise on:
It would be much appreciated! |
@marcpopMSFT can you help with @TanayParikh question above? |
@MackinnonBuck was able to run the last round of baseline generation without issue. This may be a local issue on my end, @MackinnonBuck if you still have the environment setup from last week do you mind re-running the baseline generation? |
…0822.24 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages From Version 7.0.0-rc.1.22411.12 -> To Version 8.0.0-alpha.1.22422.24
The errors I'm seeing look like:
Is that caused from |
@eerhardt, I updated Reflection.Metadata version in HostModel in dotnet/runtime to 6.0.0 in order to stay in sync with version used by SDK and MSBuild repos, meanwhile SDK was updated to 6.0.1, so we just need to |
This reverts commit c53cffb.
…ing that Microsoft.NET.Build.Tasks doesn't load S.R.M 6.0.0.1 while HostModel uses MSBuild's 6.0.0.0 copy
…ub.com:dotnet/sdk into darc-main-b89ef279-c278-4e48-9a05-29840bb46c47
@eerhardt I've got the S.R.M situation handled. I'll fix it |
@danmoseley , I'd ping the template engine folks for that one. Sounds like ending up in a state with too many templates. That could be because of our transition to 8.0 which is still in progress. |
@dotnet/templating-engine-maintainers can you help with error above blocking codeflow? |
@TanayParikh it looks like we are on track to be green though. can we merge at that point ? I'm not clear whether that error is blocking. |
If all the tests pass, I'd merge and we can fix forward if there are further issues to address (as a lot of work went into this PR to get it green). Main is going to be in an odd state for a few weeks anyway. |
Looks good to me! |
Yay good job all. |
🎉 |
This pull request updates the following dependencies
From https://github.com/dotnet/runtime