Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/roslyn #28520

Merged
merged 24 commits into from
Oct 20, 2022

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Oct 12, 2022

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: 03acf5d2-59bd-494b-c390-08d8e9750d9d
  • Build: 20221019.12
  • Date Produced: October 19, 2022 11:20:58 PM UTC
  • Commit: 50b404de631906144f43261fa1abeae8f40b75ef
  • Branch: refs/heads/main-vs-deps

…012.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22512.3
@dotnet-maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/roslyn:

@dotnet/roslyn-infrastructure

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/roslyn) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

…012.11

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22512.11
…012.14

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22512.14
@build-analysis build-analysis bot mentioned this pull request Oct 13, 2022
2 tasks
…012.16

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22512.16
…013.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22513.1
…013.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22513.3
…013.5

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22513.5
@nagilson
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

…013.11

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22513.11
…013.17

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22513.17
…013.25

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22513.25
…013.26

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22513.26
…014.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22514.4
…014.11

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22514.11
…017.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22517.2
…017.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22517.3
@marek-safar
Copy link
Contributor

There seems to be analyzer catching more mistakes in template tests or verification not excluded correctly.

@vlada-shubina @donJoseLuis could you handle this?

@vlada-shubina vlada-shubina added the Area-dotnet new the item is related to dotnet new command label Oct 17, 2022
@vlada-shubina
Copy link
Member

vlada-shubina commented Oct 17, 2022

@marek-safar is there anyone from roslyn team to check these errors?

they refer to XUnit MemberData, and I believe they are false positive as there is no array in line mentioned.
Error is:

\src\Tests\dotnet-new.Tests\CommonTemplatesTests.cs(329,10): error CA1825: Avoid unnecessary zero-length array allocations.  Use Array.Empty<object>() instead.

Line 329 is:

[MemberData(nameof(TopLevelProgramSupport_Data))]

It looks either position or whole check is incorrect. Thank you.

@marek-safar
Copy link
Contributor

@jaredpar who can follow up on Roslyn side?

@jaredpar
Copy link
Member

jaredpar commented Oct 17, 2022

@jmarolf, @333fred

The error is actually from an analyzer, not roslyn

D:\a\_work\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\ParserTests\InstantiateTests.cs(210,10): error CA1825: Avoid unnecessary zero-length array allocations.  Use Array.Empty<object>() instead

The call sites are

        [Theory]
        [MemberData(nameof(CanEvaluateTemplateToRunData))]

Which map to

        public MemberDataAttribute(string memberName, params object[] parameters)
            : base(memberName, parameters) { }

That makes me believe it's related to the following PR where we fixed a bug in IOperation that caused it to correctly hit more attribute locations. At the same time the warning seems off here. Under the hood we should be using Array<T>.Empty in the compiler (most TF support it) so not 100% sure what is going on here.

@jmarolf jmarolf self-assigned this Oct 17, 2022
…017.9

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22517.9
@marcpopMSFT
Copy link
Member

Same failure in #28519

@333fred
Copy link
Member

333fred commented Oct 18, 2022

It's a false-postive fixed by dotnet/roslyn-analyzers#6114. The version of analyzers used will need be updated to include that fix.

…018.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22518.6
@333fred
Copy link
Member

333fred commented Oct 18, 2022

An alternative solution to quickly unblock is to suppress these false positives. That's what we did with the VS build.

…018.9

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22518.9
…018.11

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22518.11
…018.15

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22518.15
…019.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22519.7
…019.10

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22519.10
dotnet-maestro bot and others added 2 commits October 20, 2022 00:28
…019.12

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.4.0-3.22511.14 -> To Version 4.5.0-1.22519.12
@333fred 333fred requested a review from a team as a code owner October 20, 2022 00:38
@dotnet-maestro dotnet-maestro bot merged commit 3a31c64 into main Oct 20, 2022
@dotnet-maestro dotnet-maestro bot deleted the darc-main-0f76c4e0-2805-4a54-ad75-031602dd24ca branch October 20, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeFlow Area-dotnet new the item is related to dotnet new command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants